Merge pull request #12011 from igor-suhorukov:master

* pr/12011:
  Polish "Remove redundant casts"
  Remove redundant casts

Author: snicoll

spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/elasticsearch/ElasticsearchHealthIndicator.java

@@ -53,7 +53,7 @@ public class ElasticsearchHealthIndicator extends AbstractHealthIndicator {
 	 */
 	public ElasticsearchHealthIndicator(Client client, long responseTimeout,
 			List<String> indices) {
-		this(client, responseTimeout, (indices == null ? (String[]) null
+		this(client, responseTimeout, (indices == null ? null
 				: indices.toArray(new String[indices.size()])));
 	}
 

spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/web/reactive/AbstractWebFluxEndpointHandlerMapping.java

@@ -299,8 +299,7 @@ private Map<String, Object> getArguments(ServerWebExchange exchange,
 
 		@SuppressWarnings("unchecked")
 		private Map<String, String> getTemplateVariables(ServerWebExchange exchange) {
-			return (Map<String, String>) exchange
-					.getAttribute(HandlerMapping.URI_TEMPLATE_VARIABLES_ATTRIBUTE);
+			return exchange.getAttribute(HandlerMapping.URI_TEMPLATE_VARIABLES_ATTRIBUTE);
 		}
 
 		private Mono<ResponseEntity<Object>> handleResult(Publisher<?> result,

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/ConditionMessage.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -359,7 +359,7 @@ public ConditionMessage items(Object... items) {
 		 */
 		public ConditionMessage items(Style style, Object... items) {
 			return items(style,
-					items == null ? (Collection<?>) null : Arrays.asList(items));
+					items == null ? null : Arrays.asList(items));
 		}
 
 		/**

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration.java

@@ -265,8 +265,7 @@ private String[] replaceVendorLocations(String[] locations,
 
 		private DatabaseDriver getDatabaseDriver() {
 			try {
-				String url = (String) JdbcUtils.extractDatabaseMetaData(this.dataSource,
-						"getURL");
+				String url = JdbcUtils.extractDatabaseMetaData(this.dataSource, "getURL");
 				return DatabaseDriver.fromJdbcUrl(url);
 			}
 			catch (MetaDataAccessException ex) {

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/DatabaseLookup.java

@@ -69,7 +69,7 @@ public static Database getDatabase(DataSource dataSource) {
 			return Database.DEFAULT;
 		}
 		try {
-			String url = (String) JdbcUtils.extractDatabaseMetaData(dataSource, "getURL");
+			String url = JdbcUtils.extractDatabaseMetaData(dataSource, "getURL");
 			DatabaseDriver driver = DatabaseDriver.fromJdbcUrl(url);
 			Database database = LOOKUP.get(driver);
 			if (database != null) {

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/ansi/AnsiColors.java

@@ -94,7 +94,7 @@ private static final class LabColor {
 		private final double b;
 
 		LabColor(Integer rgb) {
-			this(rgb == null ? (Color) null : new Color(rgb));
+			this(rgb == null ? null : new Color(rgb));
 		}
 
 		LabColor(Color color) {

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jta/bitronix/PoolingDataSourceBean.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -22,7 +22,6 @@
 import java.util.Properties;
 import java.util.logging.Logger;
 
-import javax.sql.DataSource;
 import javax.sql.XAConnection;
 import javax.sql.XADataSource;
 
@@ -111,7 +110,7 @@ public XAStatefulHolder createPooledConnection(Object xaFactory, ResourceBean be
 	@Override
 	public Logger getParentLogger() throws SQLFeatureNotSupportedException {
 		try {
-			return ((DataSource) this).getParentLogger();
+			return this.getParentLogger();
 		}
 		catch (Exception ex) {
 			// Work around https://jira.codehaus.org/browse/BTM-134