Skip to content

Commit 069c31a

Browse files
committed
Map connection and read timeouts for New Relic again
Closes gh-21440
1 parent 53bf65d commit 069c31a

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/newrelic/NewRelicMetricsExportAutoConfiguration.java

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,14 @@
1717
package org.springframework.boot.actuate.autoconfigure.metrics.export.newrelic;
1818

1919
import io.micrometer.core.instrument.Clock;
20+
import io.micrometer.core.ipc.http.HttpUrlConnectionSender;
21+
import io.micrometer.newrelic.ClientProviderType;
2022
import io.micrometer.newrelic.NewRelicClientProvider;
2123
import io.micrometer.newrelic.NewRelicConfig;
24+
import io.micrometer.newrelic.NewRelicInsightsAgentClientProvider;
25+
import io.micrometer.newrelic.NewRelicInsightsApiClientProvider;
2226
import io.micrometer.newrelic.NewRelicMeterRegistry;
23-
import io.micrometer.newrelic.NewRelicMeterRegistry.Builder;
2427

25-
import org.springframework.beans.factory.ObjectProvider;
2628
import org.springframework.boot.actuate.autoconfigure.metrics.CompositeMeterRegistryAutoConfiguration;
2729
import org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration;
2830
import org.springframework.boot.actuate.autoconfigure.metrics.export.simple.SimpleMetricsExportAutoConfiguration;
@@ -67,13 +69,23 @@ public NewRelicConfig newRelicConfig() {
6769
return new NewRelicPropertiesConfigAdapter(this.properties);
6870
}
6971

72+
@Bean
73+
@ConditionalOnMissingBean
74+
public NewRelicClientProvider newRelicClientProvider(NewRelicConfig newRelicConfig) {
75+
if (newRelicConfig.clientProviderType() == ClientProviderType.INSIGHTS_AGENT) {
76+
return new NewRelicInsightsAgentClientProvider(newRelicConfig);
77+
}
78+
return new NewRelicInsightsApiClientProvider(newRelicConfig,
79+
new HttpUrlConnectionSender(this.properties.getConnectTimeout(), this.properties.getReadTimeout()));
80+
81+
}
82+
7083
@Bean
7184
@ConditionalOnMissingBean
7285
public NewRelicMeterRegistry newRelicMeterRegistry(NewRelicConfig newRelicConfig, Clock clock,
73-
ObjectProvider<NewRelicClientProvider> newRelicClientProvider) {
74-
Builder builder = NewRelicMeterRegistry.builder(newRelicConfig).clock(clock);
75-
newRelicClientProvider.ifUnique(builder::clientProvider);
76-
return builder.build();
86+
NewRelicClientProvider newRelicClientProvider) {
87+
return NewRelicMeterRegistry.builder(newRelicConfig).clock(clock).clientProvider(newRelicClientProvider)
88+
.build();
7789
}
7890

7991
}

0 commit comments

Comments
 (0)