Skip to content

Commit 01b8e2c

Browse files
committed
Polish “Replace custom Neo4j container with Testcontainers version”
See gh-15638
1 parent 316126e commit 01b8e2c

File tree

4 files changed

+17
-14
lines changed

4 files changed

+17
-14
lines changed

spring-boot-project/spring-boot-parent/pom.xml

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
<maven.version>3.5.4</maven.version>
2727
<maven-resolver.version>1.1.1</maven-resolver.version>
2828
<spock.version>1.0-groovy-2.4</spock.version>
29+
<testcontainers.version>1.10.6</testcontainers.version>
2930
<dependency-management-plugin.version>1.0.6.RELEASE</dependency-management-plugin.version>
3031
</properties>
3132
<scm>
@@ -96,16 +97,6 @@
9697
<artifactId>mockwebserver</artifactId>
9798
<version>3.9.0</version>
9899
</dependency>
99-
<dependency>
100-
<groupId>org.testcontainers</groupId>
101-
<artifactId>testcontainers</artifactId>
102-
<version>1.10.6</version>
103-
</dependency>
104-
<dependency>
105-
<groupId>org.testcontainers</groupId>
106-
<artifactId>neo4j</artifactId>
107-
<version>1.10.6</version>
108-
</dependency>
109100
<dependency>
110101
<groupId>com.vaadin.external.google</groupId>
111102
<artifactId>android-json</artifactId>
@@ -247,6 +238,16 @@
247238
<artifactId>spock-spring</artifactId>
248239
<version>${spock.version}</version>
249240
</dependency>
241+
<dependency>
242+
<groupId>org.testcontainers</groupId>
243+
<artifactId>neo4j</artifactId>
244+
<version>${testcontainers.version}</version>
245+
</dependency>
246+
<dependency>
247+
<groupId>org.testcontainers</groupId>
248+
<artifactId>testcontainers</artifactId>
249+
<version>${testcontainers.version}</version>
250+
</dependency>
250251
<dependency>
251252
<groupId>org.zeroturnaround</groupId>
252253
<artifactId>zt-zip</artifactId>

spring-boot-project/spring-boot-test-autoconfigure/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,12 +296,12 @@
296296
</dependency>
297297
<dependency>
298298
<groupId>org.testcontainers</groupId>
299-
<artifactId>testcontainers</artifactId>
299+
<artifactId>neo4j</artifactId>
300300
<scope>test</scope>
301301
</dependency>
302302
<dependency>
303303
<groupId>org.testcontainers</groupId>
304-
<artifactId>neo4j</artifactId>
304+
<artifactId>testcontainers</artifactId>
305305
<scope>test</scope>
306306
</dependency>
307307
</dependencies>

spring-boot-project/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/data/neo4j/DataNeo4jTestIntegrationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@
4747
public class DataNeo4jTestIntegrationTests {
4848

4949
@ClassRule
50-
public static Neo4jContainer neo4j = new Neo4jContainer().withAdminPassword(null);
50+
public static Neo4jContainer<?> neo4j = new Neo4jContainer<>()
51+
.withAdminPassword(null);
5152

5253
@Autowired
5354
private Session session;

spring-boot-project/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/data/neo4j/DataNeo4jTestWithIncludeFilterIntegrationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@
4444
public class DataNeo4jTestWithIncludeFilterIntegrationTests {
4545

4646
@ClassRule
47-
public static Neo4jContainer neo4j = new Neo4jContainer().withAdminPassword(null);
47+
public static Neo4jContainer<?> neo4j = new Neo4jContainer<>()
48+
.withAdminPassword(null);
4849

4950
@Autowired
5051
private ExampleService service;

0 commit comments

Comments
 (0)