using faultTolerant and processor as a Function #3880
Labels
status: duplicate
Issues that are duplicates of other issues
Comments
|
Thank you for opening this issue.
I confirm this issue happens with v4.3.2. The following sample passes with a non fault-tolerant step but fails with a import java.util.Arrays;
import java.util.function.Function;
import org.springframework.batch.core.Job;
import org.springframework.batch.core.JobParameters;
import org.springframework.batch.core.Step;
import org.springframework.batch.core.configuration.annotation.EnableBatchProcessing;
import org.springframework.batch.core.configuration.annotation.JobBuilderFactory;
import org.springframework.batch.core.configuration.annotation.StepBuilderFactory;
import org.springframework.batch.core.launch.JobLauncher;
import org.springframework.batch.item.support.ListItemReader;
import org.springframework.context.ApplicationContext;
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
@Configuration
@EnableBatchProcessing
public class GH3880 {
@Bean
public Step step(StepBuilderFactory stepBuilderFactory) {
return stepBuilderFactory.get("step")
.<Integer, Person>chunk(2)
.reader(new ListItemReader<>(Arrays.asList(1, 2, 3, 4)))
.processor((Function<Integer, Person>) integer -> new Person("foo" + integer))
.writer(items -> items.forEach(System.out::println))
// .faultTolerant()
// .skip(Exception.class)
// .skipLimit(3)
.build();
}
@Bean
public Job job(JobBuilderFactory jobBuilderFactory, StepBuilderFactory stepBuilderFactory) {
return jobBuilderFactory.get("job")
.start(step(stepBuilderFactory))
.build();
}
public static void main(String[] args) throws Exception {
ApplicationContext context = new AnnotationConfigApplicationContext(GH3880.class);
JobLauncher jobLauncher = context.getBean(JobLauncher.class);
Job job = context.getBean(Job.class);
jobLauncher.run(job, new JobParameters());
}
static class Person {
private final String name;
public Person(String name) {
this.name = name;
}
@Override
public String toString() {
return name;
}
}
}This is actually a duplicate of #3749 and the change suggested there fixes the issue. I will close this as duplicate and plan #3749 for v4.3.3. Thanks again for reporting this issue 👍 |
fmbenhassine
added
the
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
i have this step which worked fine
but after having the first NullPasswordException i restarted it and i got a strange exception
as you can see in the code i have listeners which write log after and before item reading, processing and writing
and you can see that the exception is hapening in the writer and the writer is getting an instance of Party insteads of an Intermediaire
and the log is not showing "Before Process" and "After Process" between "After Read" and "Before Write"
it is like he ignored the processor
Note that this same code was working well before that i add the faultTolerant :
without this lines the code was working and when i get an exception i could restart from the last stop point after fixing it because my ItemReader is based on AbstractItemCountingItemStreamItemReader
now with this code (with faultTolerant) i have just changed the type of the processor from Function to ItemProcessor and the code is working
it seems that the faultTolerant dont like the Function processor
The text was updated successfully, but these errors were encountered: