Skip to content

Conversation

@garyrussell
Copy link
Contributor

build.gradle Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you decided to move out of Java 7 finally?..

@garyrussell
Copy link
Contributor Author

Pushed - moved the JDK8 tests to the -test project and skip tests in the JDK 7 IO Compatibility build.

Thanks again @wilkinsona

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is an overhead.
I believe you that you have had a good testing around there.
Although I'll recheck test tasks with IO during merge.

@artembilan
Copy link
Member

That's all.
Just a couple minor concerns.

Reinstate lambdas, ignore tests in spring-rabbit-test for
JDK 7 Spring IO Compatibility builds.

Add test for class-level repeated annotations, and fix BPP.
@garyrussell
Copy link
Contributor Author

Rebased, pushed.

@garyrussell garyrussell closed this Feb 3, 2016
@garyrussell garyrussell reopened this Feb 3, 2016
@artembilan
Copy link
Member

Merged as 0c7294f.
Pay attention to the PDF overflow fix.

@artembilan artembilan closed this Feb 3, 2016
@garyrussell garyrussell deleted the AMQP-557 branch March 17, 2017 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants