Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WebServerFactoryCustomizerBeanPostProcessor registration GraalVM native compliant. #272

Closed
sdeleuze opened this issue May 27, 2020 · 1 comment
Closed

Make WebServerFactoryCustomizerBeanPostProcessor registration GraalVM native compliant. #272

sdeleuze opened this issue May 27, 2020 · 1 comment
Assignees
@sdeleuze
Labels
type: enhancement A general enhancement
Milestone
0.3.1

Comments

@sdeleuze
Copy link
Collaborator

As a follow-up of #146, depends on oracle/graal#2500.
@sdeleuze sdeleuze added this to the 0.4 milestone May 27, 2020
@sdeleuze sdeleuze self-assigned this May 27, 2020
@sdeleuze sdeleuze modified the milestones: 0.4.0, 0.3.1 Jun 6, 2020
@sdeleuze
Copy link
Collaborator Author

sdeleuze commented Jun 6, 2020 •
edited
Loading

After more work on that, context.registerBean("webServerFactoryCustomizerBeanPostProcessor", WebServerFactoryCustomizerBeanPostProcessor.class) does not work without reflection configuration due to oracle/graal#2500.

But we have an easy workaround since context.registerBean("webServerFactoryCustomizerBeanPostProcessor", WebServerFactoryCustomizerBeanPostProcessor.class, WebServerFactoryCustomizerBeanPostProcessor::new) works out of the box without any configuration.

It seems it was the only place where we did not use a lambda for calling the constructor.

Reflection entry for TomcatEmbeddedWebappClassLoader is also needed but that will be handled on spring-graalvm-native side.

@sdeleuze sdeleuze changed the title Support GraalVM native without reflection configuration Make WebServerFactoryCustomizerBeanPostProcessor registration GraalVM native compliant. Jun 6, 2020
@sdeleuze sdeleuze added the type: enhancement A general enhancement label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
0.3.1
Development

No branches or pull requests
1 participant
@sdeleuze