Skip to content

Conversation

@jialindai
Copy link
Contributor

Enable configuring config client side TLS certificate and trust store.

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #1679 into 2.2.x will decrease coverage by 0.21%.
The diff coverage is 47.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.2.x    #1679      +/-   ##
============================================
- Coverage     79.84%   79.63%   -0.22%     
- Complexity     1208     1211       +3     
============================================
  Files           156      156              
  Lines          4521     4541      +20     
  Branches        607      606       -1     
============================================
+ Hits           3610     3616       +6     
- Misses          686      698      +12     
- Partials        225      227       +2     
Impacted Files Coverage Δ Complexity Δ
...fig/client/ConfigServicePropertySourceLocator.java 72.28% <29.41%> (-4.78%) 32.00 <1.00> (+1.00) ⬇️
...rk/cloud/config/client/ConfigClientProperties.java 92.06% <100.00%> (+0.39%) 46.00 <3.00> (+3.00)
...erver/environment/NativeEnvironmentRepository.java 85.51% <0.00%> (-1.38%) 45.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bbd634...c007a81. Read the comment docs.

@jialindai
Copy link
Contributor Author

@spencergibb , could you help to review the PR?

@jialindai
Copy link
Contributor Author

@spencergibb , this PR has been updated to use common classes in spring-cloud/spring-cloud-commons#803

Could you help to review?

<artifactId>google-auth-library-oauth2-http</artifactId>
<version>0.15.0</version>
</dependency>
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanjbaxter move to test module

import org.bouncycastle.operator.ContentSigner;
import org.bouncycastle.operator.jcajce.JcaContentSignerBuilder;

public class KeyTool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanjbaxter remove and use one from commons

@ryanjbaxter ryanjbaxter merged commit c007a81 into spring-cloud:2.2.x Aug 24, 2020
@spencergibb spencergibb added this to the 2.2.5.RELEASE milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants