-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add client side TLS cert support #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.2.x #1679 +/- ##
============================================
- Coverage 79.84% 79.63% -0.22%
- Complexity 1208 1211 +3
============================================
Files 156 156
Lines 4521 4541 +20
Branches 607 606 -1
============================================
+ Hits 3610 3616 +6
- Misses 686 698 +12
- Partials 225 227 +2
Continue to review full report at Codecov.
|
|
@spencergibb , could you help to review the PR? |
|
@spencergibb , this PR has been updated to use common classes in spring-cloud/spring-cloud-commons#803 Could you help to review? |
| <artifactId>google-auth-library-oauth2-http</artifactId> | ||
| <version>0.15.0</version> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanjbaxter move to test module
| import org.bouncycastle.operator.ContentSigner; | ||
| import org.bouncycastle.operator.jcajce.JcaContentSignerBuilder; | ||
|
|
||
| public class KeyTool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanjbaxter remove and use one from commons
Enable configuring config client side TLS certificate and trust store.