Error in GenericConversionService.ConverterAdapter

Author: ferengra

SPR-9157/pom.xml

@@ -9,7 +9,7 @@
     <description>SPR-9157 - Spring 3 converter</description>
 
     <properties>
-        <java-version>1.6</java-version>
+        <java-version>1.5</java-version>
         <spring.version>3.0.7.RELEASE</spring.version>
         <slf4j.version>1.6.4</slf4j.version>
     </properties>

SPR-9157/src/main/java/org/springframework/issues/spr9157/model/EnhancedEnvironment.java

@@ -0,0 +1,11 @@
+package org.springframework.issues.spr9157.model;
+
+/**
+ * Enhanced environment.
+ * 
+ * @author ferengra
+ */
+public interface EnhancedEnvironment extends Environment {
+
+    String getDescription();
+}

SPR-9157/src/main/java/org/springframework/issues/spr9157/model/EnhancedEnvironmentImpl.java

@@ -0,0 +1,28 @@
+package org.springframework.issues.spr9157.model;
+
+/**
+ * Enhanced environment implementation.
+ * 
+ * @author ferengra
+ */
+public class EnhancedEnvironmentImpl extends EnvironmentImpl implements EnhancedEnvironment {
+    private String description;
+
+    @SuppressWarnings("unused")
+    private EnhancedEnvironmentImpl() {
+        // Hibernate
+    }
+
+    public EnhancedEnvironmentImpl(String name, String description) {
+        super(name);
+        this.description = description;
+    }
+
+    public String getDescription() {
+        return description;
+    }
+
+    public void setDescription(String description) {
+        this.description = description;
+    }
+}

SPR-9157/src/main/java/org/springframework/issues/spr9157/model/Environment.java

@@ -0,0 +1,11 @@
+package org.springframework.issues.spr9157.model;
+
+/**
+ * Environment.
+ * 
+ * @author ferengra
+ */
+public interface Environment {
+
+    String getName();
+}

SPR-9157/src/main/java/org/springframework/issues/spr9157/model/EnvironmentImpl.java

@@ -0,0 +1,58 @@
+package org.springframework.issues.spr9157.model;
+
+/**
+ * Environment implementation.
+ * 
+ * @author ferengra
+ */
+public class EnvironmentImpl implements Environment {
+    private Long id;
+    private String name;
+
+    protected EnvironmentImpl() {
+        // Hibernate
+    }
+
+    public EnvironmentImpl(String name) {
+        this.name = name;
+    }
+
+    public String getName() {
+        return name;
+    }
+
+    public void setName(String name) {
+        this.name = name;
+    }
+
+    public Long getId() {
+        return id;
+    }
+
+    @Override
+    public int hashCode() {
+        final int prime = 31;
+        int result = 1;
+        result = prime * result + ((getName() == null) ? 0 : getName().hashCode());
+        return result;
+    }
+
+    @Override
+    public boolean equals(Object obj) {
+        if (this == obj) {
+            return true;
+        }
+        if (!(obj instanceof EnhancedEnvironmentImpl)) {
+            return false;
+        }
+        EnhancedEnvironmentImpl other = (EnhancedEnvironmentImpl) obj;
+        return getName().equals(other.getName());
+    }
+
+    @Override
+    public String toString() {
+        StringBuilder builder = new StringBuilder();
+        builder.append("EnvironmentImpl [id=").append(id).append(", name=").append(name).append("]");
+        return builder.toString();
+    }
+}

SPR-9157/src/main/java/org/springframework/issues/spr9157/web/controller/EnvironmentController.java

@@ -1,9 +1,8 @@
 package org.springframework.issues.spr9157.web.controller;
 
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.issues.spr9157.Environment;
+import org.springframework.issues.spr9157.model.EnhancedEnvironment;
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RequestMethod;
@@ -12,6 +11,8 @@
 
 /**
  * Controller for managing environment.
+ * 
+ * @author ferengra
  */
 @Controller
 public class EnvironmentController {
@@ -24,7 +25,7 @@ public ModelAndView getEnvironments() {
     }
 
     @RequestMapping(value = "/environment.html", method = RequestMethod.GET)
-    public ModelAndView getEnvironment(@RequestParam Environment environment) {
+    public ModelAndView getEnvironment(@RequestParam EnhancedEnvironment environment) {
         LOG.debug("environment: {}", environment);
         ModelAndView mav = new ModelAndView("environment");
         mav.addObject("environment", environment);

SPR-9157/src/main/java/org/springframework/issues/spr9157/web/util/EnvironmentConverter.java

@@ -1,14 +1,16 @@
 package org.springframework.issues.spr9157.web.util;
 
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.core.convert.converter.Converter;
-import org.springframework.issues.spr9157.Environment;
+import org.springframework.issues.spr9157.model.EnhancedEnvironmentImpl;
+import org.springframework.issues.spr9157.model.Environment;
 import org.springframework.util.StringUtils;
 
 /**
  * Environment converter.
+ * 
+ * @author ferengra
  */
 public class EnvironmentConverter implements Converter<String, Environment> {
     private static final Logger LOG = LoggerFactory.getLogger(EnvironmentConverter.class);
@@ -18,6 +20,6 @@ public Environment convert(String source) {
         if (!StringUtils.hasText(source)) {
             return null;
         }
-        return new Environment(source.trim());
+        return new EnhancedEnvironmentImpl(source.trim(), source.trim());
     }
 }

SPR-9157/src/main/webapp/WEB-INF/spr9157-servlet.xml

@@ -46,4 +46,9 @@
             </set>
         </property>
     </bean>
+
+    <bean class="org.springframework.web.servlet.handler.SimpleMappingExceptionResolver">
+        <property name="defaultErrorView" value="errorInternal" />
+        <property name="warnLogCategory" value="spr9157" />
+    </bean>
 </beans>

SPR-9157/src/main/webapp/WEB-INF/views/environment.jsp

@@ -1,5 +1,7 @@
-<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> 
 <%@ page contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"%>
+<jsp:text>
+	<![CDATA[ <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> ]]>
+</jsp:text>
 
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>

SPR-9157/src/main/webapp/WEB-INF/views/errorInternal.jsp

@@ -0,0 +1,19 @@
+<%@ page contentType="text/html; charset=UTF-8" pageEncoding="UTF-8"%>
+<%@ page isErrorPage="true" %>
+<%@ page import="org.slf4j.LoggerFactory" %>
+<jsp:text>
+	<![CDATA[ <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> ]]>
+</jsp:text>
+
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<head>
+<title>Spring 3 Converter</title>
+</head>
+<body>
+Error<br/>
+<%
+LoggerFactory.getLogger("InternalError").error("Exception occured: ", exception);
+%>
+<%= exception.toString() %> <br/>
+</body>
+</html>