Enable debugging for any address #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
reviewed
Aug 25, 2022
| @@ -2,7 +2,7 @@ package spray.revolver | |||
|
|
|||
| case class DebugSettings(port: Int = 5005, suspend: Boolean = false) { | |||
| def toCmdLineArg: String = | |||
| "-agentlib:jdwp=transport=dt_socket,server=y,suspend=%s,address=%d".format(b2str(suspend), port) | |||
| "-agentlib:jdwp=transport=dt_socket,server=y,suspend=%s,address=*:%d".format(b2str(suspend), port) | |||
There was a problem hiding this comment.
Hmm, would this open the port on 0.0.0.0?
If you'd do that on your host system, it'd mean the port would be open for anyone who can connect to it. I expect the debugging interface allows arbitrary code execution, so perhaps this should be an opt-in option instead?
There was a problem hiding this comment.
Good point, I've updated the code to have it as an optional parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101