Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOSONAR not ignored #1034

Open
isaguimiot opened this issue Aug 22, 2024 · 2 comments
Open

NOSONAR not ignored #1034

isaguimiot opened this issue Aug 22, 2024 · 2 comments

Comments

@isaguimiot
Copy link

Issue Description

Some issues raised by findbugs have a //NOSONAR tag in the source code, but now they appear in the issues, instead of being ignored.
(see screenshot attached)
nosonar

Environment

We updated Sonarqube to 10.6 and use findbugs 4.2.7 (had to rollback after a bug was introduced in 4.2.8 : "missing bug code for keySECXXEVAL")

There's a topic on sonarqube community about this bug : https://community.sonarsource.com/t/nosonar-does-not-work/97763/4
They say it's a findbugs problem.

Could you investigate ?

@gtoison
Copy link
Contributor

gtoison commented Aug 26, 2024

As far as I know this was never a feature of the findbugs plugin, because it analyses the compiled .class files where there's no NOSONAR comment.
I suppose that SonarQube was silencing the issues raised by plugin when there was a NOSONAR comment on the line

@gtoison
Copy link
Contributor

gtoison commented Sep 3, 2024

Hello @isaguimiot
I got an answer from Colin at Sonarsource (here) and this is indeed supposed to work, even if the plugin does not check for NOSONAR
Since the problem is not reproduced in his testing, Colin is asking if you could provide a sample project reproducing the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants