Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YoutubeMusic mismatch metadata issue #1627

Closed
asmol82 opened this issue Oct 12, 2022 · 7 comments
Closed

YoutubeMusic mismatch metadata issue #1627

asmol82 opened this issue Oct 12, 2022 · 7 comments
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed

Comments

@asmol82
Copy link

asmol82 commented Oct 12, 2022

System OS

Linux

Python Version

3.9 (CPython)

Install Source

pip / PyPi

Install version / commit hash

4.0.0-rc.5

Expected Behavior vs Actual Behavior

No response

Steps to reproduce - Ensure to include actual links!

spotdl download https://open.spotify.com/album/1v0qwwfJMWT38bKyD3ik6N --audio youtube-music --format mp3 --bitrate 320k --ffmpeg-args "-ar 44100"

Traceback

LookupError: No results found for song: Василий К. - Счёт

Other details

Hello!
Faced such a problem: there is an album on youtube music, here https://music.youtube.com/playlist?list=OLAK5uy_lHycoUl9m8DYDXkDcdogjg-vUraLuRrTg, but its metadata is entered in English, unlike the original on Spotify, here https://open.spotify.com/album/1v0qwwfJMWT38bKyD3ik6N Can you tell me how can I fix this problem in the future?

@asmol82 asmol82 added the Bug Unexpected problem or unintended behavior that needs to be fixed label Oct 12, 2022
@asmol82 asmol82 changed the title YoutubeMusic metadata issue YoutubeMusic mismatch metadata issue Oct 12, 2022
@parkitny
Copy link

I have checked the code and have found the issue - The song is returned as a result, but it is not identified as a match because of the diacritic (dots) above the letter e in the song name...: tracing the code - it identifies the song: 'Счет' from the same artist, but the query song is: 'Счёт' and does not meet any of the existing criteria.

It's possible to extend the order_results function to handle this case. i.e. normalise the text (remove diacritics) and perform the check again. This should result in a stronger result than fuzzy search and will enable loose match of song names for these cases.

@xnetcat can I work on a fix for this?

@xnetcat
Copy link
Member

xnetcat commented Oct 14, 2022

results are normalized before comparisons with slugify, I am not sure if that's it. there's some debugging code in yet music.py that you can uncomment to investigate this further.

@asmol82
Copy link
Author

asmol82 commented Oct 14, 2022

Unfortunately, I'm not a developer... I was hoping that you might somehow solve this problem in future versions. This problem is not yet "burning", because other albums are downloaded normally. I tried to use Spotify metadata along with this playlist, but the script gave me, as far as I remember, a 404 error...

@xnetcat
Copy link
Member

xnetcat commented Oct 14, 2022

Unfortunately, I'm not a developer... I was hoping that you might somehow solve this problem in future versions. This problem is not yet "burning", because other albums are downloaded normally. I tried to use Spotify metadata along with this playlist, but the script gave me, as far as I remember, a 404 error...

spotipy-dev/spotipy#795

@parkitny
Copy link

Yes actually the fix is not as simple as I thought, the slugify library makes default replacements for diacritics. Sometimes the defaults do not make sense based on the language of the text. i.e. it is applying a German substitution of the Russian text. It can be fixed by providing replacements to slugify based on the language of the text - but it would require identification of which language the text string is in first. If there is an easy way to identify the language then I can add a fix. This is the suggested way to handle these cases according to this: un33k/python-slugify#45

@asmol82
Copy link
Author

asmol82 commented Oct 14, 2022

It's okay guys. I have already written a letter to an artist with whom I am well acquainted. If everything goes well, he will correct the metadata in this album himself, and then everything will be fine. Again, with the rest of the albums, everything is just fine, which allowed me to save 16 bucks on a converter like Noteburner. ;)

So it goes!

@xnetcat
Copy link
Member

xnetcat commented Oct 30, 2022

LookupError: No results found for song: Василий К. - Счёт this song is not available on youtube so spotify correctly raises and error, instead of downloading a wrong song https://www.youtube.com/watch?v=noBwXFo6-zE

@xnetcat xnetcat closed this as completed Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed
Projects
None yet
Development

No branches or pull requests

3 participants