Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output has been changed with RSpec 2.99.0.beta1 #248

Open
untidy-hair opened this issue Dec 27, 2013 · 3 comments
Open

Output has been changed with RSpec 2.99.0.beta1 #248

untidy-hair opened this issue Dec 27, 2013 · 3 comments

Comments

@untidy-hair
Copy link

Hi folks,

I always spork in one terminal (say terminal A), and after that, rspec in another terminal. (say terminal B)

With RSpec 2.14.x, the test results are displayed on terminal B.
But when I try RSpec 2.99.0.beta1, the test results are on terminal A.

I haven't found any clues so far.
I like the results to show up on terminal B where I input like 'rspec some_spec.rb'.
Am I missing something? (Or this is the matter of RSpec itself?)

Using spork 1.0.0rc4.

Thanks!

@untidy-hair
Copy link
Author

Looks like this issue happens because rspec-core's configuration (about output stream) has been changed.

I could avoid it by changing lib/spork/test_framework/rspec.rb line 10.

From:

  else
    ::RSpec::Core::CommandLine.new(argv).run(stderr, stdout)
  end

To:

  else
    configuration = ::RSpec::configuration
    configuration.output_stream = stdout
    ::RSpec::Core::CommandLine.new(argv, configuration).run(stderr, stdout)
  end

I'm reluctant to make a pull request now because I don't know if this issue is (will be) common enough.
In addition, passing stdout twice to RSpec doesn't seem reasonable to me.

@agis
Copy link

agis commented Apr 21, 2015

We also ran into this while upgrading to 2.99.0, ended up forking spork and applying @untidy-hair's patch. I'm curious, is this issue present in rspec 3?

@untidy-hair
Copy link
Author

@agis-
I'm sorry for the late reply. Probably not. I ended up stopping to use spork actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants