Skip to content

Commit 7928675

Browse files
committed
Update test_validators.py
Updated and fixed the float validator test case added by the user for the PR #384
1 parent 6b0d620 commit 7928675

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

tests/searchcommands/test_validators.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,10 @@ def test(integer):
208208

209209
def test_float(self):
210210
# Float validator test
211+
import random
211212

212-
maxsize = sys.maxsize
213-
minsize = -(sys.maxsize - 1)
213+
maxsize = random.random() + 1
214+
minsize = random.random() - 1
214215

215216
validator = validators.Float()
216217

@@ -240,27 +241,25 @@ def test(float_val):
240241
self.assertEqual(validator.__call__(0), 0)
241242
self.assertEqual(validator.__call__(1.154), 1.154)
242243
self.assertEqual(validator.__call__(888.51), 888.51)
243-
self.assertEqual(validator.__call__(2 * maxsize), float(2 * maxsize))
244+
self.assertEqual(validator.__call__(2 * maxsize), (2 * maxsize))
244245
self.assertRaises(ValueError, validator.__call__, -1)
245246
self.assertRaises(ValueError, validator.__call__, -1111.00578)
246247
self.assertRaises(ValueError, validator.__call__, -0.005)
247248

248249
validator = validators.Float(minimum=1, maximum=maxsize)
249250
self.assertEqual(validator.__call__(1), float(1))
250-
self.assertEqual(validator.__call__(100.111), 100.111)
251-
self.assertEqual(validator.__call__(9999.0), 9999.0)
252-
self.assertEqual(validator.__call__(maxsize), float(maxsize))
251+
self.assertEqual(validator.__call__(maxsize), maxsize)
253252
self.assertRaises(ValueError, validator.__call__, 0)
254253
self.assertRaises(ValueError, validator.__call__, 0.9999)
255-
self.assertRaises(ValueError, validator.__call__, -199)
256254
self.assertRaises(ValueError, validator.__call__, maxsize + 1)
257255

258-
validator = validators.Float(minimum=-1, maximum=1)
259-
self.assertEqual(validator.__call__(0), float(0))
256+
validator = validators.Float(minimum=minsize, maximum=maxsize)
257+
self.assertEqual(validator.__call__(minsize), minsize)
260258
self.assertEqual(validator.__call__(0.123456), 0.123456)
259+
self.assertEqual(validator.__call__(0), float(0))
261260
self.assertEqual(validator.__call__(-0.012), -0.012)
262-
self.assertRaises(ValueError, validator.__call__, -1.1)
263-
self.assertRaises(ValueError, validator.__call__, 100.123456)
261+
self.assertEqual(validator.__call__(maxsize), maxsize)
262+
self.assertRaises(ValueError, validator.__call__, minsize - 1)
264263
self.assertRaises(ValueError, validator.__call__, maxsize + 1)
265264

266265
return

0 commit comments

Comments
 (0)