Skip to content

fix: Add NOT to escape chars as spl special char #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Feb 16, 2022
Merged

fix: Add NOT to escape chars as spl special char #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d692c
fix: Add NOT to escape chars as spl special char
nandinivij Feb 15, 2022
64013e1
test: Add to test NOT keyword
nandinivij Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pytest_splunk_addon/standard_lib/requirement_tests/test_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ def escape_char_event(self, event):
"OVER",
"WHERE",
"LIKE",
"NOT",
]
event = event.replace("\\", "\\\\")
bounded_asterisk = re.search(
Expand Down
2 changes: 1 addition & 1 deletion tests/requirement_test_scripted/sample_requirement_test_scripted.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<comment>Unix service information. Data is collected from live instance. Data is generated from systemctl command. </comment>
</source>
<raw>
<![CDATA[Tue May 26 01:38:02 PDT 2020 type=systemctl UNIT=whoopsie.service, LOADED=not-found, ACTIVE=inactive, SUB=dead, DESCRIPTION="whoopsie.service"]]>
<![CDATA[Tue May 26 01:38:02 PDT 2020 type=systemctl UNIT=whoopsie.service, LOADED= NOT -found, ACTIVE=inactive, SUB=dead, DESCRIPTION="whoopsie.service"]]>
</raw>
<cim>
<models>
Expand Down
1 change: 1 addition & 0 deletions tests/unit/tests_standard_lib/test_requirement_tests/test_test_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ def test_check_xml_format(et_parse_mock, is_xml_valid, expected_output):
("OVER", "SESSION \\OVER CREATED"),
("WHERE", "SESSION \\WHERE CREATED"),
("LIKE", "SESSION \\LIKE CREATED"),
("NOT", "SESSION \\NOT CREATED"),
],
)
def test_escape_char_event(escape_char, expected_output):
Expand Down