Skip to content

fix: field extraction error message #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021
Merged

fix: field extraction error message #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions pytest_splunk_addon/standard_lib/requirement_tests/test_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
import json
import logging
import pytest
import re
Expand Down Expand Up @@ -50,7 +51,15 @@ def compare(self, keyValueSPL, keyValueXML, escapedKeyValue):
for key, value in keyValueXML.items():
res = key in keyValueprocessedSPL and value == keyValueprocessedSPL[key]
if (not res) and (key not in escapedKeyValue):
dict_missing_key_value.update({key: value})
valueinsplunk = None
if key in keyValueSPL.keys():
valueinsplunk = keyValueSPL[key]
dict_missing_key_value.update(
{
"Key value in requirement file: " + key: value,
"Key value extracted by Splunk: " + key: valueinsplunk,
}
)
flag = False
return flag, dict_missing_key_value

Expand Down Expand Up @@ -193,19 +202,13 @@ def test_requirement_params(
keyValue_dict_SPL, key_values_xml, exceptions_dict
)
self.logger.info(f"Field mapping check: {field_extraction_check}")
mismapped_key_value_pair = {}
for key, value in missing_key_value.items():
if key in keyValue_dict_SPL.keys():
valueInSplunk = keyValue_dict_SPL[key]
mismapped_key_value_pair.update({key: valueInSplunk})

assert datamodel_check and field_extraction_check, (
f" Issue with either field extraction or data model.\nsearch={search}\n"
f" data model check: {datamodel_check} \n"
f" data model in requirement file {model_datalist}\n "
f" data model extracted by TA {list(datamodel_based_on_tag.keys())}\n"
f" Field_extraction_check: {field_extraction_check} \n"
f" Key value not extracted by TA: {missing_key_value} \n"
f" Mismatched key value: {mismapped_key_value_pair}\n"
f" Field extraction errors: {json.dumps(missing_key_value, indent=4)} \n"
f" sourcetype of ingested event: {sourcetype} \n"
)