refactor: cache parsed results

Author: artemrys

pytest_splunk_addon/standard_lib/addon_parser/eventtype_parser.py

@@ -42,13 +42,15 @@ def __init__(self, splunk_app_path: str):
 
     @property
     def eventtypes(self) -> Optional[Dict]:
+        if self._eventtypes is not None:
+            return self._eventtypes
         eventtypes_conf_path = os.path.join(
             self.splunk_app_path, "default", "eventtypes.conf"
         )
         LOGGER.info("Parsing eventtypes.conf")
         self._conf_parser.read(eventtypes_conf_path)
-        result = self._conf_parser.item_dict()
-        return result if result else None
+        self._eventtypes = self._conf_parser.item_dict()
+        return self._eventtypes if self._eventtypes else None
 
     def get_eventtypes(self) -> Optional[Generator]:
         """

pytest_splunk_addon/standard_lib/addon_parser/savedsearches_parser.py

@@ -42,13 +42,15 @@ def __init__(self, splunk_app_path: str):
 
     @property
     def savedsearches(self) -> Optional[Dict]:
+        if self._savedsearches is not None:
+            return self._savedsearches
         savedsearches_conf_path = os.path.join(
             self.splunk_app_path, "default", "savedsearches.conf"
         )
         LOGGER.info("Parsing savedsearches.conf")
         self._conf_parser.read(savedsearches_conf_path)
-        result = self._conf_parser.item_dict()
-        return result if result else None
+        self._savedsearches = self._conf_parser.item_dict()
+        return self._savedsearches if self._savedsearches else None
 
     def get_savedsearches(self) -> Optional[Generator]:
         """

pytest_splunk_addon/standard_lib/addon_parser/tags_parser.py

@@ -43,8 +43,8 @@ def __init__(self, splunk_app_path: str):
     def tags(self) -> Optional[Dict]:
         if self._tags is not None:
             return self._tags
-        LOGGER.info("Parsing tags.conf")
         tags_conf_path = os.path.join(self.splunk_app_path, "default", "tags.conf")
+        LOGGER.info("Parsing tags.conf")
         self._conf_parser.read(tags_conf_path)
         self._tags = self._conf_parser.item_dict()
         return self._tags if self._tags else None