sonarqube suggestions

Author: mredolatti

src/Utils/NoOpTracerHook.php

@@ -4,7 +4,7 @@
 
 class NoOpTracerHook implements TracerHook
 {
-    function on(int $method, int $event, ?array $args)
+    public function on(int $method, int $event, ?array $args)
     {
     }
 }

src/Utils/TracerHook.php

@@ -4,5 +4,5 @@
 
 interface TracerHook
 {
-    function on(int $method, int $event, ?array $args);
+    public function on(int $method, int $event, ?array $args);
 }

tests/Link/Transfer/ConnectionFactoryTest.php

@@ -7,10 +7,11 @@
 class ConnectionFactoryTest extends TestCase
 {
 
-    public function testHappyExchange(): void
+    public function testProperTimeouts(): void
     {
 	$c = new \ReflectionClass(ConnectionFactory::class);
 	$m = $c->getMethod('formatTimeout');
+        $m->setAccessible(true);
 	$this->assertEquals(['sec' => 1, 'usec' => 0], $m->invoke(null, ['sec' =>1, 'usec' => 0]));
 	$this->assertEquals(['sec' => 1, 'usec' => 0], $m->invoke(null, 0));
 	$this->assertEquals(['sec' => 1, 'usec' => 0], $m->invoke(null, 1000));
@@ -23,6 +24,7 @@ public function testInvalidArrayTimeout(): void
     {
     	$c = new \ReflectionClass(ConnectionFactory::class);
 	$m = $c->getMethod('formatTimeout');
+        $m->setAccessible(true);
         $this->expectExceptionMessage("timeout must either be an int (milliseconds) or an array with keys 'sec' & 'usec'");
         $m->invoke(null, []);
     }
@@ -31,6 +33,7 @@ public function testNonArrayNonIntTimeout(): void
     {
     	$c = new \ReflectionClass(ConnectionFactory::class);
 	$m = $c->getMethod('formatTimeout');
+        $m->setAccessible(true);
         $this->expectExceptionMessage("timeout must either be an int (milliseconds) or an array with keys 'sec' & 'usec'");
         $m->invoke(null, 98.7);
     }