From 8b356ff3afc32c8ba3c071c0f85802950f9d92f7 Mon Sep 17 00:00:00 2001
From: Andreas Gohr <andi@splitbrain.org>
Date: Wed, 13 Sep 2023 15:36:54 +0200
Subject: [PATCH 1/3] use new test workflows

---
 .github/workflows/dokuwiki.yml     | 11 +++++++
 .github/workflows/phpTestLinux.yml | 52 ------------------------------
 2 files changed, 11 insertions(+), 52 deletions(-)
 create mode 100644 .github/workflows/dokuwiki.yml
 delete mode 100644 .github/workflows/phpTestLinux.yml

diff --git a/.github/workflows/dokuwiki.yml b/.github/workflows/dokuwiki.yml
new file mode 100644
index 00000000..31b4b081
--- /dev/null
+++ b/.github/workflows/dokuwiki.yml
@@ -0,0 +1,11 @@
+name: DokuWiki Default Tasks
+on:
+  push:
+  pull_request:
+  schedule:
+    - cron: '22 12 25 * *'
+
+
+jobs:
+  all:
+    uses: dokuwiki/github-action/.github/workflows/all.yml@main
diff --git a/.github/workflows/phpTestLinux.yml b/.github/workflows/phpTestLinux.yml
deleted file mode 100644
index 4853ad1c..00000000
--- a/.github/workflows/phpTestLinux.yml
+++ /dev/null
@@ -1,52 +0,0 @@
-name: PHP Tests on Linux
-
-on: [push, pull_request]
-
-jobs:
-    testLinux:
-        name: PHP ${{ matrix.php-versions }} DokuWiki ${{ matrix.dokuwiki-branch }}
-        runs-on: ubuntu-latest
-        if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
-
-        strategy:
-            matrix:
-                php-versions: ['7.2', '7.3', '7.4', '8.0']
-                dokuwiki-branch: [ 'master', 'stable']
-                exclude:
-                    -   dokuwiki-branch: 'stable'
-                        php-versions: '8.0'
-            fail-fast: false
-
-        steps:
-            - name: Checkout
-              uses: actions/checkout@v2
-
-            - name: Setup PHP
-              uses: shivammathur/setup-php@v2
-              with:
-                  php-version: ${{ matrix.php-versions }}
-                  extensions: mbstring, intl, PDO, pdo_sqlite, bz2
-
-            - name: Setup problem matchers
-              run: |
-                echo ::add-matcher::${{ runner.tool_cache }}/php.json
-                echo ::add-matcher::${{ runner.tool_cache }}/phpunit.json
-
-            - name: Download DokuWiki Test-setup
-              run: wget https://raw.github.com/splitbrain/dokuwiki-travis/master/travis.sh
-
-            - name: Run DokuWiki Test-setup
-              env:
-                  CI_SERVER: 1
-                  DOKUWIKI: ${{ matrix.dokuwiki-branch }}
-              run: sh travis.sh
-
-            - name: Setup PHPUnit
-              run: |
-                  php _test/fetchphpunit.php
-                  cd _test
-
-            - name: Run PHPUnit
-              run: |
-                cd _test
-                php phpunit.phar --verbose --stderr --group plugin_dw2pdf

From 852931daed0aa7c73fc4da5d421d2c117decf509 Mon Sep 17 00:00:00 2001
From: Andreas Gohr <andi@splitbrain.org>
Date: Wed, 13 Sep 2023 16:13:49 +0200
Subject: [PATCH 2/3] rector and php sniffer cleanups

---
 DokuImageProcessorDecorator.php  |  57 ++++++-----
 DokuPDF.class.php                |  33 +++----
 MenuItem.php                     |  14 +--
 _test/ActionPagenameSortTest.php |   6 +-
 action.php                       | 161 +++++++++++++++++--------------
 conf/default.php                 |   1 +
 conf/metadata.php                |   2 +-
 renderer.php                     | 155 ++++++++++++++++-------------
 syntax/exportlink.php            |   6 +-
 syntax/pagesetting.php           |  38 ++++----
 10 files changed, 259 insertions(+), 214 deletions(-)

diff --git a/DokuImageProcessorDecorator.php b/DokuImageProcessorDecorator.php
index 8ac719af..2c2c2571 100644
--- a/DokuImageProcessorDecorator.php
+++ b/DokuImageProcessorDecorator.php
@@ -2,10 +2,10 @@
 
 namespace dokuwiki\plugin\dw2pdf;
 
-require_once __DIR__ . '/vendor/autoload.php';
-
-class DokuImageProcessorDecorator extends \Mpdf\Image\ImageProcessor {
+use Mpdf\Image\ImageProcessor;
 
+class DokuImageProcessorDecorator extends ImageProcessor
+{
     /**
      * Override the mpdf _getImage function
      *
@@ -14,14 +14,21 @@ class DokuImageProcessorDecorator extends \Mpdf\Image\ImageProcessor {
      * making sure that only cached file paths are passed to mpdf. It also
      * takes care of checking image ACls.
      */
-    public function getImage (&$file, $firsttime = true, $allowvector = true, $orig_srcpath = false, $interpolation = false) {
-        list($file, $orig_srcpath) = self::adjustGetImageLinks($file, $orig_srcpath);
+    public function getImage(
+        &$file,
+        $firsttime = true,
+        $allowvector = true,
+        $orig_srcpath = false,
+        $interpolation = false
+    ) {
+        [$file, $orig_srcpath] = self::adjustGetImageLinks($file, $orig_srcpath);
 
         return parent::getImage($file, $firsttime, $allowvector, $orig_srcpath, $interpolation);
     }
 
 
-    public static function adjustGetImageLinks($file, $orig_srcpath) {
+    public static function adjustGetImageLinks($file, $orig_srcpath)
+    {
         global $conf;
 
         // build regex to parse URL back to media info
@@ -29,42 +36,44 @@ public static function adjustGetImageLinks($file, $orig_srcpath) {
         $re = str_replace('xxx123yyy', '([^&\?]*)', $re);
 
         // extract the real media from a fetch.php uri and determine mime
-        if(preg_match("/^$re/", $file, $m) ||
+        if (
+            preg_match("/^$re/", $file, $m) ||
             preg_match('/[&?]media=([^&?]*)/', $file, $m)
         ) {
             $media = rawurldecode($m[1]);
-            list($ext, $mime) = mimetype($media);
+            [$ext, $mime] = mimetype($media);
         } else {
-            list($ext, $mime) = mimetype($file);
+            [$ext, $mime] = mimetype($file);
         }
 
         // local files
         $local = '';
-        if(substr($file, 0, 9) == 'dw2pdf://') {
+        if (substr($file, 0, 9) == 'dw2pdf://') {
             // support local files passed from plugins
             $local = substr($file, 9);
-        } elseif(!preg_match('/(\.php|\?)/', $file)) {
+        } elseif (!preg_match('/(\.php|\?)/', $file)) {
             $re = preg_quote(DOKU_URL, '/');
             // directly access local files instead of using HTTP, skip dynamic content
             $local = preg_replace("/^$re/i", DOKU_INC, $file);
         }
 
-        if(substr($mime, 0, 6) == 'image/') {
-            if(!empty($media)) {
+        if (substr($mime, 0, 6) == 'image/') {
+            if (!empty($media)) {
                 // any size restrictions?
-                $w = $h = 0;
+                $w = 0;
+                $h = 0;
                 $rev = '';
-                if(preg_match('/[?&]w=(\d+)/', $file, $m)) $w = $m[1];
-                if(preg_match('/[?&]h=(\d+)/', $file, $m)) $h = $m[1];
-                if(preg_match('/[&?]rev=(\d+)/', $file, $m)) $rev = $m[1];
+                if (preg_match('/[?&]w=(\d+)/', $file, $m)) $w = $m[1];
+                if (preg_match('/[?&]h=(\d+)/', $file, $m)) $h = $m[1];
+                if (preg_match('/[&?]rev=(\d+)/', $file, $m)) $rev = $m[1];
 
-                if(media_isexternal($media)) {
+                if (media_isexternal($media)) {
                     $local = media_get_from_URL($media, $ext, -1);
-                    if(!$local) $local = $media; // let mpdf try again
+                    if (!$local) $local = $media; // let mpdf try again
                 } else {
                     $media = cleanID($media);
                     //check permissions (namespace only)
-                    if(auth_quickaclcheck(getNS($media) . ':X') < AUTH_READ) {
+                    if (auth_quickaclcheck(getNS($media) . ':X') < AUTH_READ) {
                         $file = '';
                         $local = '';
                     } else {
@@ -73,18 +82,18 @@ public static function adjustGetImageLinks($file, $orig_srcpath) {
                 }
 
                 //handle image resizing/cropping
-                if($w && file_exists($local)) {
-                    if($h) {
+                if ($w && file_exists($local)) {
+                    if ($h) {
                         $local = media_crop_image($local, $ext, $w, $h);
                     } else {
                         $local = media_resize_image($local, $ext, $w, $h);
                     }
                 }
-            } elseif(!file_exists($local) && media_isexternal($file)) { // fixed external URLs
+            } elseif (!file_exists($local) && media_isexternal($file)) { // fixed external URLs
                 $local = media_get_from_URL($file, $ext, $conf['cachetime']);
             }
 
-            if($local) {
+            if ($local) {
                 $file = $local;
                 $orig_srcpath = $local;
             }
diff --git a/DokuPDF.class.php b/DokuPDF.class.php
index e5ec2a0c..a64fffa3 100644
--- a/DokuPDF.class.php
+++ b/DokuPDF.class.php
@@ -1,4 +1,10 @@
 <?php
+
+// phpcs:disable: PSR1.Methods.CamelCapsMethodName.NotCamelCaps
+
+use Mpdf\Mpdf;
+use dokuwiki\plugin\dw2pdf\DokuImageProcessorDecorator;
+
 /**
  * Wrapper around the mpdf library class
  *
@@ -7,18 +13,8 @@
  *
  * @author Andreas Gohr <andi@splitbrain.org>
  */
-
-use dokuwiki\plugin\dw2pdf\DokuImageProcessorDecorator;
-
-require_once __DIR__ . '/vendor/autoload.php';
-
-/**
- * Class DokuPDF
- * Some DokuWiki specific extentions
- */
-class DokuPDF extends \Mpdf\Mpdf
+class DokuPDF extends Mpdf
 {
-
     /**
      * DokuPDF constructor.
      *
@@ -26,12 +22,16 @@ class DokuPDF extends \Mpdf\Mpdf
      * @param string $orientation
      * @param int $fontsize
      */
-    function __construct($pagesize = 'A4', $orientation = 'portrait', $fontsize = 11, $docLang = 'en')
+    public function __construct($pagesize = 'A4', $orientation = 'portrait', $fontsize = 11, $docLang = 'en')
     {
         global $conf;
         global $lang;
 
-        if (!defined('_MPDF_TEMP_PATH')) define('_MPDF_TEMP_PATH', $conf['tmpdir'] . '/dwpdf/' . rand(1, 1000) . '/');
+        require_once __DIR__ . '/vendor/autoload.php';
+
+        if (!defined('_MPDF_TEMP_PATH')) {
+            define('_MPDF_TEMP_PATH', $conf['tmpdir'] . '/dwpdf/' . random_int(1, 1000) . '/');
+        }
         io_mkdir_p(_MPDF_TEMP_PATH);
 
         $format = $pagesize;
@@ -48,7 +48,6 @@ function __construct($pagesize = 'A4', $orientation = 'portrait', $fontsize = 11
                 break;
             default:
                 $mode = 'UTF-8-s';
-
         }
 
         parent::__construct([
@@ -76,7 +75,7 @@ function __construct($pagesize = 'A4', $orientation = 'portrait', $fontsize = 11
     /**
      * Cleanup temp dir
      */
-    function __destruct()
+    public function __destruct()
     {
         io_rmdir(_MPDF_TEMP_PATH, true);
     }
@@ -87,11 +86,9 @@ function __destruct()
      * @param string $path
      * @param string $basepath
      */
-    function GetFullPath(&$path, $basepath = '')
+    public function GetFullPath(&$path, $basepath = '')
     {
         $path = htmlspecialchars_decode($path);
         parent::GetFullPath($path, $basepath);
     }
-
-
 }
diff --git a/MenuItem.php b/MenuItem.php
index 6aaf6b5d..735e8ed0 100644
--- a/MenuItem.php
+++ b/MenuItem.php
@@ -11,8 +11,8 @@
  *
  * @package dokuwiki\plugin\dw2pdf
  */
-class MenuItem extends AbstractItem {
-
+class MenuItem extends AbstractItem
+{
     /** @var string do action for this plugin */
     protected $type = 'export_pdf';
 
@@ -22,13 +22,14 @@ class MenuItem extends AbstractItem {
     /**
      * MenuItem constructor.
      */
-    public function __construct() {
+    public function __construct()
+    {
         parent::__construct();
         global $REV, $DATE_AT;
 
-        if($DATE_AT) {
+        if ($DATE_AT) {
             $this->params['at'] = $DATE_AT;
-        } elseif($REV) {
+        } elseif ($REV) {
             $this->params['rev'] = $REV;
         }
     }
@@ -38,7 +39,8 @@ public function __construct() {
      *
      * @return string
      */
-    public function getLabel() {
+    public function getLabel()
+    {
         $hlp = plugin_load('action', 'dw2pdf');
         return $hlp->getLang('export_pdf_button');
     }
diff --git a/_test/ActionPagenameSortTest.php b/_test/ActionPagenameSortTest.php
index d946e599..f7188d6c 100644
--- a/_test/ActionPagenameSortTest.php
+++ b/_test/ActionPagenameSortTest.php
@@ -17,8 +17,8 @@ public function testDirectPagenameSort()
     {
         $action = new \action_plugin_dw2pdf();
 
-        $this->assertLessThan(0, $action->_pagenamesort(['id' => 'bar'], ['id' => 'bar:start']));
-        $this->assertGreaterThan(0, $action->_pagenamesort(['id' => 'bar:bar'], ['id' => 'bar:start']));
+        $this->assertLessThan(0, $action->cbPagenameSort(['id' => 'bar'], ['id' => 'bar:start']));
+        $this->assertGreaterThan(0, $action->cbPagenameSort(['id' => 'bar:bar'], ['id' => 'bar:start']));
     }
 
     /**
@@ -96,7 +96,7 @@ public function testPagenameSort($comment, $expected)
 
         // run sort
         $action = new \action_plugin_dw2pdf();
-        usort($input, [$action, '_pagenamesort']);
+        usort($input, [$action, 'cbPagenameSort']);
 
         $this->assertSame($prepared, $input);
     }
diff --git a/action.php b/action.php
index cde0d63d..2c03b857 100644
--- a/action.php
+++ b/action.php
@@ -1,32 +1,31 @@
 <?php
+
+use dokuwiki\Cache\Cache;
+use dokuwiki\Extension\ActionPlugin;
+use dokuwiki\Extension\Event;
+use dokuwiki\Extension\EventHandler;
+use dokuwiki\plugin\dw2pdf\MenuItem;
+use dokuwiki\StyleUtils;
+use Mpdf\MpdfException;
+
 /**
  * dw2Pdf Plugin: Conversion from dokuwiki content to pdf.
  *
+ * Export html content to pdf, for different url parameter configurations
+ * DokuPDF which extends mPDF is used for generating the pdf from html.
+ *
  * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
  * @author     Luigi Micco <l.micco@tiscali.it>
  * @author     Andreas Gohr <andi@splitbrain.org>
  */
-
-/**
- * Class action_plugin_dw2pdf
- *
- * Export html content to pdf, for different url parameter configurations
- * DokuPDF which extends mPDF is used for generating the pdf from html.
- */
-
-use dokuwiki\Cache\Cache;
-use dokuwiki\plugin\dw2pdf\MenuItem;
-use dokuwiki\StyleUtils;
-use Mpdf\MpdfException;
-
-class action_plugin_dw2pdf extends DokuWiki_Action_Plugin
+class action_plugin_dw2pdf extends ActionPlugin
 {
     /**
      * Settings for current export, collected from url param, plugin config, global config
      *
      * @var array
      */
-    protected $exportConfig = null;
+    protected $exportConfig;
     /** @var string template name, to use templates from dw2pdf/tpl/<template name> */
     protected $tpl;
     /** @var string title of exported pdf */
@@ -68,7 +67,7 @@ public function getCurrentBookChapter()
      *
      * @param Doku_Event_Handler $controller
      */
-    public function register(Doku_Event_Handler $controller)
+    public function register(EventHandler $controller)
     {
         $controller->register_hook('ACTION_ACT_PREPROCESS', 'BEFORE', $this, 'convert');
         $controller->register_hook('TEMPLATE_PAGETOOLS_DISPLAY', 'BEFORE', $this, 'addbutton');
@@ -80,7 +79,7 @@ public function register(Doku_Event_Handler $controller)
      *
      * @param Doku_Event $event
      */
-    public function convert(Doku_Event $event)
+    public function convert(Event $event)
     {
         global $REV, $DATE_AT;
         global $conf, $INPUT;
@@ -91,7 +90,7 @@ public function convert(Doku_Event $event)
 
         try {
             //collect pages and check permissions
-            list($this->title, $this->list) = $this->collectExportablePages($event);
+            [$this->title, $this->list] = $this->collectExportablePages($event);
 
             if ($event->data === 'export_pdf' && ($REV || $DATE_AT)) {
                 $cachefile = tempnam($conf['tmpdir'] . '/dwpdf', 'dw2pdf_');
@@ -117,7 +116,7 @@ public function convert(Doku_Event $event)
         } catch (Exception $e) {
             if ($INPUT->has('selection')) {
                 http_status(400);
-                print $e->getMessage();
+                echo $e->getMessage();
                 exit();
             } else {
                 //prevent Action/Export()
@@ -141,7 +140,7 @@ public function convert(Doku_Event $event)
      * @return array
      * @throws Exception
      */
-    protected function collectExportablePages(Doku_Event $event)
+    protected function collectExportablePages(Event $event)
     {
         global $ID, $REV;
         global $INPUT;
@@ -169,7 +168,6 @@ protected function collectExportablePages(Doku_Event $event)
             if (!file_exists($filename)) {
                 throw new Exception($this->getLang('notexist'));
             }
-
         } elseif ($event->data == 'export_pdfns') {
             //check input for title and ns
             if (!$title = $INPUT->str('book_title')) {
@@ -220,9 +218,9 @@ protected function collectExportablePages(Doku_Event $event)
             //sorting
             if (count($result) > 0) {
                 if ($order == 'date') {
-                    usort($result, [$this, '_datesort']);
+                    usort($result, [$this, 'cbDateSort']);
                 } elseif ($order == 'pagename' || $order == 'natural') {
-                    usort($result, [$this, '_pagenamesort']);
+                    usort($result, [$this, 'cbPagenameSort']);
                 }
             }
 
@@ -237,7 +235,6 @@ protected function collectExportablePages(Doku_Event $event)
                     }
                 }
             }
-
         } elseif (!empty($_COOKIE['list-pagelist'])) {
             /** @deprecated  April 2016 replaced by localStorage version of Bookcreator */
             //is in Bookmanager of bookcreator plugin a title given?
@@ -248,7 +245,6 @@ protected function collectExportablePages(Doku_Event $event)
             }
 
             $list = explode("|", $_COOKIE['list-pagelist']);
-
         } elseif ($INPUT->has('selection')) {
             //handle Bookcreator requests based at localStorage
 //            if(!checkSecurityToken()) {
@@ -258,7 +254,7 @@ protected function collectExportablePages(Doku_Event $event)
 //            }
 
             $list = json_decode($INPUT->str('selection', '', true), true);
-            if (!is_array($list) || empty($list)) {
+            if (!is_array($list) || $list === []) {
                 throw new Exception($this->getLang('empty'));
             }
 
@@ -267,7 +263,6 @@ protected function collectExportablePages(Doku_Event $event)
             if (empty($title)) {
                 throw new Exception($this->getLang('needtitle'));
             }
-
         } elseif ($INPUT->has('savedselection')) {
             //export a saved selection of the Bookcreator Plugin
             if (plugin_isdisabled('bookcreator')) {
@@ -283,7 +278,6 @@ protected function collectExportablePages(Doku_Event $event)
             if (empty($title)) {
                 throw new Exception($this->getLang('needtitle'));
             }
-
         } else {
             //show empty bookcreator message
             throw new Exception($this->getLang('empty'));
@@ -301,8 +295,8 @@ protected function collectExportablePages(Doku_Event $event)
         $list = array_filter($list, 'strlen'); //use of strlen() callback prevents removal of pagename '0'
 
         //if selection contains forbidden pages throw (overridable) warning
-        if (!$INPUT->bool('book_skipforbiddenpages') && !empty($skippedpages)) {
-            $msg = hsc(join(', ', $skippedpages));
+        if (!$INPUT->bool('book_skipforbiddenpages') && $skippedpages !== []) {
+            $msg = hsc(implode(', ', $skippedpages));
             throw new Exception(sprintf($this->getLang('forbidden'), $msg));
         }
 
@@ -319,7 +313,7 @@ protected function prepareCache(&$depends)
     {
         global $REV;
 
-        $cachekey = join(',', $this->list)
+        $cachekey = implode(',', $this->list)
             . $REV
             . $this->getExportConfig('template')
             . $this->getExportConfig('pagesize')
@@ -327,7 +321,7 @@ protected function prepareCache(&$depends)
             . $this->getExportConfig('font-size')
             . $this->getExportConfig('doublesided')
             . $this->getExportConfig('headernumber')
-            . ($this->getExportConfig('hasToC') ? join('-', $this->getExportConfig('levels')) : '0')
+            . ($this->getExportConfig('hasToC') ? implode('-', $this->getExportConfig('levels')) : '0')
             . $this->title;
         $cache = new Cache($cachekey, '.dw2.pdf');
 
@@ -358,8 +352,8 @@ protected function prepareCache(&$depends)
 
         $depends['files'] = array_map('wikiFN', $this->list);
         $depends['files'][] = __FILE__;
-        $depends['files'][] = dirname(__FILE__) . '/renderer.php';
-        $depends['files'][] = dirname(__FILE__) . '/mpdf/mpdf.php';
+        $depends['files'][] = __DIR__ . '/renderer.php';
+        $depends['files'][] = __DIR__ . '/mpdf/mpdf.php';
         $depends['files'] = array_merge(
             $depends['files'],
             $dependencies,
@@ -376,7 +370,7 @@ protected function prepareCache(&$depends)
      * @param string $date_at
      * @return null|string
      */
-    protected function p_wiki_dw2pdf($id, $rev = '', $date_at = '')
+    protected function wikiToDW2PDF($id, $rev = '', $date_at = '')
     {
         $file = wikiFN($id, $rev);
 
@@ -388,7 +382,8 @@ protected function p_wiki_dw2pdf($id, $rev = '', $date_at = '')
         $ID = $id;
 
         if ($rev || $date_at) {
-            $ret = p_render('dw2pdf', p_get_instructions(io_readWikiPage($file, $id, $rev)), $info, $date_at); //no caching on old revisions
+            //no caching on old revisions
+            $ret = p_render('dw2pdf', p_get_instructions(io_readWikiPage($file, $id, $rev)), $info, $date_at);
         } else {
             $ret = p_cached_output($file, 'dw2pdf', $id);
         }
@@ -413,8 +408,10 @@ protected function generatePDF($cachefile, $event)
         if ($event->data == 'export_pdf') { //only one page is exported
             $rev = $REV;
             $date_at = $DATE_AT;
-        } else { //we are exporting entire namespace, ommit revisions
-            $rev = $date_at = '';
+        } else {
+            //we are exporting entire namespace, ommit revisions
+            $rev = '';
+            $date_at = '';
         }
 
         //some shortcuts to export settings
@@ -424,7 +421,7 @@ protected function generatePDF($cachefile, $event)
         $watermark = $this->getExportConfig('watermark');
 
         // initialize PDF library
-        require_once(dirname(__FILE__) . "/DokuPDF.class.php");
+        require_once(__DIR__ . "/DokuPDF.class.php");
 
         $mpdf = new DokuPDF(
             $this->getExportConfig('pagesize'),
@@ -463,7 +460,7 @@ protected function generatePDF($cachefile, $event)
         }
 
         // load the template
-        $template = $this->load_template();
+        $template = $this->loadTemplate();
 
         // prepare HTML header styles
         $html = '';
@@ -479,7 +476,7 @@ protected function generatePDF($cachefile, $event)
         $styles .= 'div.dw2pdf-landscape { page:landscape-page }';
         $styles .= '@page portrait-page { size:portrait }';
         $styles .= 'div.dw2pdf-portrait { page:portrait-page }';
-        $styles .= $this->load_css();
+        $styles .= $this->loadCSS();
 
         $mpdf->WriteHTML($styles, 1);
 
@@ -500,8 +497,10 @@ protected function generatePDF($cachefile, $event)
             $html .= $body_start;
         }
         if ($hasToC) {
-            //Note: - for double-sided document the ToC is always on an even number of pages, so that the following content is on a correct odd/even page
-            //      - first page of ToC starts always at odd page (so eventually an additional blank page is included before)
+            //Note: - for double-sided document the ToC is always on an even number of pages, so that the
+            //        following content is on a correct odd/even page
+            //      - first page of ToC starts always at odd page (so eventually an additional blank page
+            //        is included before)
             //      - there is no page numbering at the pages of the ToC
             $mpdf->TOCpagebreakByArray([
                 'toc-preHTML' => '<h2>' . $this->getLang('tocheader') . '</h2>',
@@ -520,12 +519,12 @@ protected function generatePDF($cachefile, $event)
             $this->currentBookChapter = $counter;
             $counter++;
 
-            $pagehtml = $this->p_wiki_dw2pdf($page, $rev, $date_at);
+            $pagehtml = $this->wikiToDW2PDF($page, $rev, $date_at);
             //file doesn't exists
             if ($pagehtml == '') {
                 continue;
             }
-            $pagehtml .= $this->page_depend_replacements($template['cite'], $page);
+            $pagehtml .= $this->pageDependReplacements($template['cite'], $page);
             if ($counter < $no_pages) {
                 $pagehtml .= '<pagebreak />';
             }
@@ -591,7 +590,7 @@ protected function sendPDFFile($cachefile)
             http_rangeRequest($fp, filesize($cachefile), 'application/pdf');
         } else {
             header("HTTP/1.0 500 Internal Server Error");
-            print "Could not read file - bad permissions?";
+            echo "Could not read file - bad permissions?";
         }
         exit();
     }
@@ -601,7 +600,7 @@ protected function sendPDFFile($cachefile)
      *
      * @return array
      */
-    protected function load_template()
+    protected function loadTemplate()
     {
         global $ID;
         global $conf;
@@ -659,14 +658,14 @@ protected function load_template()
         // set HTML element
         $html = str_replace(array_keys($replace), array_values($replace), $html);
         //TODO For bookcreator $ID (= bookmanager page) makes no sense
-        $output['html'] = $this->page_depend_replacements($html, $ID);
+        $output['html'] = $this->pageDependReplacements($html, $ID);
 
         // cover page
         $coverfile = DOKU_PLUGIN . 'dw2pdf/tpl/' . $this->tpl . '/cover.html';
         if (file_exists($coverfile)) {
             $output['cover'] = file_get_contents($coverfile);
             $output['cover'] = str_replace(array_keys($replace), array_values($replace), $output['cover']);
-            $output['cover'] = $this->page_depend_replacements($output['cover'], $ID);
+            $output['cover'] = $this->pageDependReplacements($output['cover'], $ID);
             $output['cover'] .= '<pagebreak />';
         }
 
@@ -676,7 +675,7 @@ protected function load_template()
             $output['back'] = '<pagebreak />';
             $output['back'] .= file_get_contents($backfile);
             $output['back'] = str_replace(array_keys($replace), array_values($replace), $output['back']);
-            $output['back'] = $this->page_depend_replacements($output['back'], $ID);
+            $output['back'] = $this->pageDependReplacements($output['back'], $ID);
         }
 
         // citation box
@@ -694,7 +693,7 @@ protected function load_template()
      * @param string $id pageid
      * @return string
      */
-    protected function page_depend_replacements($raw, $id)
+    protected function pageDependReplacements($raw, $id)
     {
         global $REV, $DATE_AT;
 
@@ -702,8 +701,12 @@ protected function page_depend_replacements($raw, $id)
         $qr_code = '';
         if ($this->getConf('qrcodescale')) {
             $url = hsc(wl($id, '', '&', true));
-            $size = floatval($this->getConf('qrcodescale'));
-            $qr_code = '<barcode type="QR" code="' . $url . '" error="Q" disableborder="1" class="qrcode" size="' . $size . '" />';
+            $size = (float)$this->getConf('qrcodescale');
+            $qr_code = sprintf(
+                '<barcode type="QR" code="%s" error="Q" disableborder="1" class="qrcode" size="%s" />',
+                $url,
+                $size
+            );
         }
         // prepare replacements
         $replace['@ID@'] = $id;
@@ -722,7 +725,7 @@ protected function page_depend_replacements($raw, $id)
 
         // let other plugins define their own replacements
         $evdata = ['id' => $id, 'replace' => &$replace, 'content' => &$content];
-        $event = new Doku_Event('PLUGIN_DW2PDF_REPLACE', $evdata);
+        $event = new Event('PLUGIN_DW2PDF_REPLACE', $evdata);
         if ($event->advise_before()) {
             $content = str_replace(array_keys($replace), array_values($replace), $raw);
         }
@@ -733,7 +736,7 @@ protected function page_depend_replacements($raw, $id)
         // @DATE(<date>[, <format>])@
         $content = preg_replace_callback(
             '/@DATE\((.*?)(?:,\s*(.*?))?\)@/',
-            [$this, 'replacedate'],
+            [$this, 'replaceDate'],
             $content
         );
 
@@ -748,7 +751,7 @@ protected function page_depend_replacements($raw, $id)
      * @param array $match with [0]=>whole match, [1]=> first subpattern, [2] => second subpattern
      * @return string
      */
-    function replacedate($match)
+    public function replaceDate($match)
     {
         global $conf;
         //no 2nd argument for default date format
@@ -761,7 +764,7 @@ function replacedate($match)
     /**
      * Load all the style sheets and apply the needed replacements
      */
-    protected function load_css()
+    protected function loadCSS()
     {
         global $conf;
         //reuse the CSS dispatcher functions without triggering the main function
@@ -774,10 +777,11 @@ protected function load_css()
                 DOKU_INC . 'lib/styles/screen.css' => DOKU_BASE . 'lib/styles/',
                 DOKU_INC . 'lib/styles/print.css' => DOKU_BASE . 'lib/styles/',
             ],
-            $this->css_pluginPDFstyles(),
+            $this->cssPluginPDFstyles(),
             [
                 DOKU_PLUGIN . 'dw2pdf/conf/style.css' => DOKU_BASE . 'lib/plugins/dw2pdf/conf/',
-                DOKU_PLUGIN . 'dw2pdf/tpl/' . $this->tpl . '/style.css' => DOKU_BASE . 'lib/plugins/dw2pdf/tpl/' . $this->tpl . '/',
+                DOKU_PLUGIN . 'dw2pdf/tpl/' . $this->tpl . '/style.css' =>
+                    DOKU_BASE . 'lib/plugins/dw2pdf/tpl/' . $this->tpl . '/',
                 DOKU_PLUGIN . 'dw2pdf/conf/style.local.css' => DOKU_BASE . 'lib/plugins/dw2pdf/conf/',
             ]
         );
@@ -817,7 +821,7 @@ protected function load_css()
      *
      * @author Andreas Gohr <andi@splitbrain.org>
      */
-    protected function css_pluginPDFstyles()
+    protected function cssPluginPDFstyles()
     {
         $list = [];
         $plugins = plugin_list();
@@ -845,7 +849,16 @@ protected function css_pluginPDFstyles()
         }
 
         // template support
-        foreach (['pdf.css', 'pdf.less', 'css/pdf.css', 'css/pdf.less', 'styles/pdf.css', 'styles/pdf.less'] as $file) {
+        foreach (
+            [
+                     'pdf.css',
+                     'pdf.less',
+                     'css/pdf.css',
+                     'css/pdf.less',
+                     'styles/pdf.css',
+                     'styles/pdf.less'
+                 ] as $file
+        ) {
             if (file_exists(tpl_incdir() . $file)) {
                 $list[tpl_incdir() . $file] = tpl_basedir() . $file;
             }
@@ -871,7 +884,7 @@ public function getExportedPages()
      * @param array $b
      * @return int
      */
-    public function _datesort($a, $b)
+    public function cbDateSort($a, $b)
     {
         if ($b['rev'] < $a['rev']) return -1;
         if ($b['rev'] > $a['rev']) return 1;
@@ -884,7 +897,7 @@ public function _datesort($a, $b)
      * @param array $b
      * @return int
      */
-    public function _pagenamesort($a, $b)
+    public function cbPagenameSort($a, $b)
     {
         global $conf;
 
@@ -951,8 +964,8 @@ protected function loadExportConfig()
         $levels = [];
         if ($hasToC) {
             $toclevels = $INPUT->str('toclevels', $this->getConf('toclevels'), true);
-            list($top_input, $max_input) = array_pad(explode('-', $toclevels, 2), 2, '');
-            list($top_conf, $max_conf) = array_pad(explode('-', $this->getConf('toclevels'), 2), 2, '');
+            [$top_input, $max_input] = array_pad(explode('-', $toclevels, 2), 2, '');
+            [$top_conf, $max_conf] = array_pad(explode('-', $this->getConf('toclevels'), 2), 2, '');
             $bounds_input = [
                 'top' => [
                     (int)$top_input,
@@ -1025,7 +1038,7 @@ public function getExportConfig($name, $notset = false)
      *
      * @param Doku_Event $event
      */
-    public function addbutton(Doku_Event $event)
+    public function addbutton(Event $event)
     {
         global $ID, $REV, $DATE_AT;
 
@@ -1039,13 +1052,13 @@ public function addbutton(Doku_Event $event)
 
             // insert button at position before last (up to top)
             $event->data['items'] = array_slice($event->data['items'], 0, -1, true) +
-                ['export_pdf' =>
-                    '<li>'
-                    . '<a href="' . wl($ID, $params) . '"  class="action export_pdf" rel="nofollow" title="' . $this->getLang('export_pdf_button') . '">'
-                    . '<span>' . $this->getLang('export_pdf_button') . '</span>'
-                    . '</a>'
-                    . '</li>'
-                ] +
+                ['export_pdf' => sprintf(
+                    '<li><a href="%s" class="%s" rel="nofollow" title="%s"><span>%s</span></a></li>',
+                    wl($ID, $params),
+                    'action export_pdf',
+                    $this->getLang('export_pdf_button'),
+                    $this->getLang('export_pdf_button')
+                )] +
                 array_slice($event->data['items'], -1, 1, true);
         }
     }
@@ -1055,7 +1068,7 @@ public function addbutton(Doku_Event $event)
      *
      * @param Doku_Event $event
      */
-    public function addsvgbutton(Doku_Event $event)
+    public function addsvgbutton(Event $event)
     {
         global $INFO;
         if ($event->data['view'] != 'page' || !$this->getConf('showexportbutton')) {
diff --git a/conf/default.php b/conf/default.php
index 98915402..77aae8d1 100644
--- a/conf/default.php
+++ b/conf/default.php
@@ -1,4 +1,5 @@
 <?php
+
 $conf['pagesize']         = 'A4';
 $conf['orientation']      = 'portrait';
 $conf['font-size']        = 11;
diff --git a/conf/metadata.php b/conf/metadata.php
index 4a17a9f3..321242f0 100644
--- a/conf/metadata.php
+++ b/conf/metadata.php
@@ -1,4 +1,5 @@
 <?php
+
 $meta['pagesize']         = array('string');
 $meta['orientation']      = array('multichoice', '_choices' => array('portrait', 'landscape'));
 $meta['font-size']        = array('numeric');
@@ -13,4 +14,3 @@
 $meta['usestyles']        = array('string');
 $meta['qrcodescale']       = array('string', '_pattern' => '/^(|\d+(\.\d+)?)$/');
 $meta['showexportbutton'] = array('onoff');
-
diff --git a/renderer.php b/renderer.php
index 72c45603..9ad67371 100644
--- a/renderer.php
+++ b/renderer.php
@@ -1,23 +1,20 @@
 <?php
+
+// phpcs:disable: PSR1.Methods.CamelCapsMethodName.NotCamelCaps
+// phpcs:disable: PSR2.Methods.MethodDeclaration.Underscore
+
 /**
  * DokuWiki Plugin dw2pdf (Renderer Component)
+ * Render xhtml suitable as input for mpdf library
  *
  * @license GPL 2 http://www.gnu.org/licenses/gpl-2.0.html
  * @author  Andreas Gohr <gohr@cosmocode.de>
  */
-
-// must be run within Dokuwiki
-if(!defined('DOKU_INC')) die();
-
-/**
- * Render xhtml suitable as input for mpdf library
- */
-class renderer_plugin_dw2pdf extends Doku_Renderer_xhtml {
-
+class renderer_plugin_dw2pdf extends Doku_Renderer_xhtml
+{
     private $lastHeaderLevel = -1;
     private $originalHeaderLevel = 0;
     private $difference = 0;
-    private $current_bookmark_level = 0;
     private static $header_count = [];
     private static $previous_level = 0;
 
@@ -26,16 +23,18 @@ class renderer_plugin_dw2pdf extends Doku_Renderer_xhtml {
      *
      * @var action_plugin_dw2pdf
      */
-    private $actioninstance = null;
+    private $actioninstance;
 
     /**
      * load action plugin instance
      */
-    public function __construct() {
+    public function __construct()
+    {
         $this->actioninstance = plugin_load('action', 'dw2pdf');
     }
 
-    public function document_start() {
+    public function document_start()
+    {
         global $ID;
 
         parent::document_start();
@@ -47,7 +46,7 @@ public function document_start() {
         $this->doc .= "<a name=\"{$pid}__\">";
         $this->doc .= "</a>";
 
-        $this->header_count[1] = $this->actioninstance->getCurrentBookChapter();
+        self::$header_count[1] = $this->actioninstance->getCurrentBookChapter();
     }
 
     /**
@@ -56,8 +55,9 @@ public function document_start() {
      * @param $format
      * @return bool
      */
-    public function canRender($format) {
-        if($format == 'xhtml') return true;
+    public function canRender($format)
+    {
+        if ($format == 'xhtml') return true;
         return false;
     }
 
@@ -68,8 +68,9 @@ public function canRender($format) {
      * @param int $level from 1 (highest) to 6 (lowest)
      * @param int $pos
      */
-    public function header($text, $level, $pos, $returnonly = false) {
-        if(!$text) return; //skip empty headlines
+    public function header($text, $level, $pos, $returnonly = false)
+    {
+        if (!$text) return; //skip empty headlines
         global $ID;
 
         $hid = $this->_headerToLink($text, true);
@@ -82,42 +83,47 @@ public function header($text, $level, $pos, $returnonly = false) {
         $hid = $pid . '__' . $hid;
 
 
-	// retrieve numbered headings option
+        // retrieve numbered headings option
         $isnumberedheadings = $this->actioninstance->getExportConfig('headernumber');
 
         $header_prefix = "";
-	if ($isnumberedheadings) {
-		if ($level > 0) {
-        	    if ($this->previous_level > $level ) {
-	                for ($i=$level+1; $i<=$this->previous_level; $i++) {
-				$this->header_count[$i]=0;
-	                }
-	            }
-	        }
-		$this->header_count[$level]++;
-
-        	// $header_prefix = "";
-	        for ($i=1; $i<=$level; $i++) {
-	            $header_prefix .= $this->header_count[$i].".";
-	 	}
-	}
+        if ($isnumberedheadings) {
+            if ($level > 0) {
+                if (self::$previous_level > $level) {
+                    for ($i = $level + 1; $i <= self::$previous_level; $i++) {
+                        self::$header_count[$i] = 0;
+                    }
+                }
+            }
+            self::$header_count[$level]++;
+
+            // $header_prefix = "";
+            for ($i = 1; $i <= $level; $i++) {
+                $header_prefix .= self::$header_count[$i] . ".";
+            }
+        }
 
         // add PDF bookmark
         $bookmark = '';
         $maxbookmarklevel = $this->actioninstance->getExportConfig('maxbookmarks');
         // 0: off, 1-6: show down to this level
-        if($maxbookmarklevel && $maxbookmarklevel >= $level) {
+        if ($maxbookmarklevel && $maxbookmarklevel >= $level) {
             $bookmarklevel = $this->calculateBookmarklevel($level);
-            $bookmark = '<bookmark content="' . $header_prefix." ". $this->_xmlEntities($text) . '" level="' . ($bookmarklevel) . '" />';
+            $bookmark = sprintf(
+                '<bookmark content="%s %s" level="%d" />',
+                $header_prefix,
+                $this->_xmlEntities($text),
+                $bookmarklevel
+            );
         }
 
         // print header
         $this->doc .= DOKU_LF . "<h$level>$bookmark";
-        $this->doc .= $header_prefix."<a name=\"$hid\">";
+        $this->doc .= $header_prefix . "<a name=\"$hid\">";
         $this->doc .= $this->_xmlEntities($text);
         $this->doc .= "</a>";
         $this->doc .= "</h$level>" . DOKU_LF;
-	$this->previous_level = $level;
+        self::$previous_level = $level;
     }
 
     /**
@@ -127,22 +133,23 @@ public function header($text, $level, $pos, $returnonly = false) {
      * @param int $level 1 (highest) to 6 (lowest)
      * @return int
      */
-    protected function calculateBookmarklevel($level) {
-        if($this->lastHeaderLevel == -1) {
+    protected function calculateBookmarklevel($level)
+    {
+        if ($this->lastHeaderLevel == -1) {
             $this->lastHeaderLevel = $level;
         }
         $step = $level - $this->lastHeaderLevel;
-        if($step > 1) {
-            $this->difference = $this->difference + ($step - 1);
+        if ($step > 1) {
+            $this->difference += $step - 1;
         }
-        if($step < 0) {
+        if ($step < 0) {
             $this->difference = min($this->difference, $level - $this->originalHeaderLevel);
             $this->difference = max($this->difference, 0);
         }
 
         $bookmarklevel = $level - $this->difference;
 
-        if($step > 1) {
+        if ($step > 1) {
             $this->originalHeaderLevel = $bookmarklevel;
         }
 
@@ -162,7 +169,8 @@ protected function calculateBookmarklevel($level) {
      *
      * @see Doku_Renderer_xhtml::locallink
      */
-    function locallink($hash, $name = null, $returnonly = false) {
+    public function locallink($hash, $name = null, $returnonly = false)
+    {
         global $ID;
         $name = $this->_getLinkTitle($name, $hash, $isImage);
         $hash = $this->_headerToLink($hash);
@@ -179,26 +187,33 @@ function locallink($hash, $name = null, $returnonly = false) {
     /**
      * Wrap centered media in a div to center it
      *
-     * @param string $src       media ID
-     * @param string $title     descriptive text
-     * @param string $align     left|center|right
-     * @param int    $width     width of media in pixel
-     * @param int    $height    height of media in pixel
-     * @param string $cache     cache|recache|nocache
-     * @param bool   $render    should the media be embedded inline or just linked
+     * @param string $src media ID
+     * @param string $title descriptive text
+     * @param string $align left|center|right
+     * @param int $width width of media in pixel
+     * @param int $height height of media in pixel
+     * @param string $cache cache|recache|nocache
+     * @param bool $render should the media be embedded inline or just linked
      * @return string
      */
-    function _media($src, $title = NULL, $align = NULL, $width = NULL,
-                    $height = NULL, $cache = NULL, $render = true) {
+    public function _media(
+        $src,
+        $title = null,
+        $align = null,
+        $width = null,
+        $height = null,
+        $cache = null,
+        $render = true
+    ) {
 
         $out = '';
-        if($align == 'center') {
+        if ($align == 'center') {
             $out .= '<div align="center" style="text-align: center">';
         }
 
         $out .= parent::_media($src, $title, $align, $width, $height, $cache, $render);
 
-        if($align == 'center') {
+        if ($align == 'center') {
             $out .= '</div>';
         }
 
@@ -210,7 +225,8 @@ function _media($src, $title = NULL, $align = NULL, $width = NULL,
      *
      * @param string $acronym
      */
-    function acronym($acronym) {
+    public function acronym($acronym)
+    {
         $this->doc .= $this->_xmlEntities($acronym);
     }
 
@@ -220,11 +236,12 @@ function acronym($acronym) {
      * @param array $link
      * @return string
      */
-    function _formatLink($link) {
+    public function _formatLink($link)
+    {
 
         // for internal links contains the title the pageid
-        if(in_array($link['title'], $this->actioninstance->getExportedPages())) {
-            list(/* $url */, $hash) = array_pad(explode('#', $link['url'], 2), 2, '');
+        if (in_array($link['title'], $this->actioninstance->getExportedPages())) {
+            [/* url */, $hash] = sexplode('#', $link['url'], 2, '');
 
             $check = false;
             $pid = sectionID($link['title'], $check);
@@ -232,16 +249,21 @@ function _formatLink($link) {
         }
 
         // prefix interwiki links with interwiki icon
-        if($link['name'][0] != '<' && preg_match('/\binterwiki iw_(.\w+)\b/', $link['class'], $m)) {
-            if(file_exists(DOKU_INC . 'lib/images/interwiki/' . $m[1] . '.png')) {
+        if ($link['name'][0] != '<' && preg_match('/\binterwiki iw_(.\w+)\b/', $link['class'], $m)) {
+            if (file_exists(DOKU_INC . 'lib/images/interwiki/' . $m[1] . '.png')) {
                 $img = DOKU_BASE . 'lib/images/interwiki/' . $m[1] . '.png';
-            } elseif(file_exists(DOKU_INC . 'lib/images/interwiki/' . $m[1] . '.gif')) {
+            } elseif (file_exists(DOKU_INC . 'lib/images/interwiki/' . $m[1] . '.gif')) {
                 $img = DOKU_BASE . 'lib/images/interwiki/' . $m[1] . '.gif';
             } else {
                 $img = DOKU_BASE . 'lib/images/interwiki.png';
             }
 
-            $link['name'] = '<img src="' . $img . '" width="16" height="16" style="vertical-align: middle" class="' . $link['class'] . '" />' . $link['name'];
+            $link['name'] = sprintf(
+                '<img src="%s" width="16" height="16" style="vertical-align: middle" class="%s" />%s',
+                $img,
+                $link['class'],
+                $link['name']
+            );
         }
         return parent::_formatLink($link);
     }
@@ -254,13 +276,12 @@ function _formatLink($link) {
      * @param bool $returnonly
      * @return string|void
      */
-    function emaillink($address, $name = NULL, $returnonly = false) {
+    public function emaillink($address, $name = null, $returnonly = false)
+    {
         global $conf;
         $old = $conf['mailguard'];
         $conf['mailguard'] = 'none';
         parent::emaillink($address, $name, $returnonly);
         $conf['mailguard'] = $old;
     }
-
 }
-
diff --git a/syntax/exportlink.php b/syntax/exportlink.php
index baccbd4c..d75dbed3 100644
--- a/syntax/exportlink.php
+++ b/syntax/exportlink.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * DokuWiki Plugin dw2pdf (Syntax Component)
  *
@@ -8,14 +9,14 @@
  * @author     Sam Wilson <sam@samwilson.id.au>
  */
 
+use dokuwiki\Extension\SyntaxPlugin;
 use dokuwiki\File\PageResolver;
 
 /**
  * Syntax for page specific directions for mpdf library
  */
-class syntax_plugin_dw2pdf_exportlink extends DokuWiki_Syntax_Plugin
+class syntax_plugin_dw2pdf_exportlink extends SyntaxPlugin
 {
-
     /**
      * Syntax Type
      *
@@ -96,5 +97,4 @@ public function render($format, Doku_Renderer $renderer, $data)
         }
         return false;
     }
-
 }
diff --git a/syntax/pagesetting.php b/syntax/pagesetting.php
index 253ca968..34e4b4ef 100644
--- a/syntax/pagesetting.php
+++ b/syntax/pagesetting.php
@@ -1,4 +1,7 @@
 <?php
+
+use dokuwiki\Extension\SyntaxPlugin;
+
 /**
  * DokuWiki Plugin dw2pdf (Syntax Component)
  *
@@ -7,14 +10,8 @@
  * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
  * @author     Sam Wilson <sam@samwilson.id.au>
  */
-/* Must be run within Dokuwiki */
-if(!defined('DOKU_INC')) die();
-
-/**
- * Syntax for page specific directions for mpdf library
- */
-class syntax_plugin_dw2pdf_pagesetting extends DokuWiki_Syntax_Plugin {
-
+class syntax_plugin_dw2pdf_pagesetting extends SyntaxPlugin
+{
     /**
      * Syntax Type
      *
@@ -22,7 +19,8 @@ class syntax_plugin_dw2pdf_pagesetting extends DokuWiki_Syntax_Plugin {
      *
      * @return string
      */
-    public function getType() {
+    public function getType()
+    {
         return 'substition';
     }
 
@@ -31,7 +29,8 @@ public function getType() {
      *
      * @return int
      */
-    public function getSort() {
+    public function getSort()
+    {
         return 40;
     }
 
@@ -42,14 +41,16 @@ public function getSort() {
      *
      * @return string
      */
-    public function getPType() {
+    public function getPType()
+    {
         return 'block';
     }
 
     /**
      * @param string $mode
      */
-    public function connectTo($mode) {
+    public function connectTo($mode)
+    {
         $this->Lexer->addSpecialPattern('~~PDF:(?:LANDSCAPE|PORTRAIT)~~', $mode, 'plugin_dw2pdf_pagesetting');
     }
 
@@ -62,8 +63,9 @@ public function connectTo($mode) {
      * @param   Doku_Handler $handler The Doku_Handler object
      * @return  bool|array Return an array with all data you want to use in render, false don't add an instruction
      */
-    public function handle($match, $state, $pos, Doku_Handler $handler) {
-        return array($match, $state, $pos);
+    public function handle($match, $state, $pos, Doku_Handler $handler)
+    {
+        return [$match, $state, $pos];
     }
 
     /**
@@ -74,13 +76,13 @@ public function handle($match, $state, $pos, Doku_Handler $handler) {
      * @param array         $data     data created by handler()
      * @return  boolean                 rendered correctly? (however, returned value is not used at the moment)
      */
-    public function render($mode, Doku_Renderer $renderer, $data) {
-        if($mode == 'xhtml') {
+    public function render($mode, Doku_Renderer $renderer, $data)
+    {
+        if ($mode == 'xhtml') {
             $orientation = strtolower(substr($data[0], 6, -2));
             $renderer->doc .= "<div class='dw2pdf-$orientation'></div>" . DOKU_LF;
             return true;
         }
         return false;
     }
-
-}
\ No newline at end of file
+}

From 0e451a24d85a215ef851794f20d6a2358cff4d10 Mon Sep 17 00:00:00 2001
From: Andreas Gohr <andi@splitbrain.org>
Date: Wed, 13 Sep 2023 16:18:57 +0200
Subject: [PATCH 3/3] require autoloader during test

Usually the autoloader is initialized fromt the DokuPDF constructor.
This is not called during individual ImageProcessor class tests.
---
 _test/DokuImageProcessorTest.php | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/_test/DokuImageProcessorTest.php b/_test/DokuImageProcessorTest.php
index a15dfd04..556cadf9 100644
--- a/_test/DokuImageProcessorTest.php
+++ b/_test/DokuImageProcessorTest.php
@@ -13,6 +13,12 @@
  */
 class DokuImageProcessorTest extends DokuWikiTest
 {
+    public static function setUpBeforeClass(): void
+    {
+        parent::setUpBeforeClass();
+        require_once __DIR__ . '/../vendor/autoload.php';
+    }
+
 
     /**
      * @return array the Testdata