Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Added listeners for FilesystemManager and LogManager #77

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

tarampampam
Copy link
Collaborator

@tarampampam tarampampam commented Jan 13, 2022

Description

Added

  • Give the current App instance to FilesystemManager (listener RebindFilesystemManagerListener)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@tarampampam tarampampam self-assigned this Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #77 (8d5ae0d) into master (d8643d6) will increase coverage by 0.37%.
The diff coverage is 90.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
+ Coverage     75.45%   75.82%   +0.37%     
- Complexity      321      331      +10     
============================================
  Files            61       63       +2     
  Lines           827      848      +21     
============================================
+ Hits            624      643      +19     
- Misses          203      205       +2     
Impacted Files Coverage Δ
src/Defaults.php 100.00% <ø> (ø)
src/Listeners/RebindFilesystemManagerListener.php 88.88% <88.88%> (ø)
src/Listeners/FlushMonologStateListener.php 91.66% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8643d6...8d5ae0d. Read the comment docs.

@tarampampam tarampampam changed the title Give the current App instance to FilesystemManager Added listeners for FilesystemManager and LogManager Jan 13, 2022
@tarampampam tarampampam marked this pull request as ready for review January 13, 2022 08:23
@tarampampam tarampampam merged commit 58d5c0c into master Jan 13, 2022
@tarampampam tarampampam deleted the sync-upstream branch January 13, 2022 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant