Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Please add ES Module support #50

Open
litan1106 opened this issue Jan 11, 2022 · 2 comments
Open

Feature Request: Please add ES Module support #50

litan1106 opened this issue Jan 11, 2022 · 2 comments

Comments

@litan1106
Copy link

zoom-vanilla.js doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix.

@spinningarrow
Copy link
Owner

This is pretty accurate since the original zoom.js was written at a time before ES modules were common. Where do you see this notice, and is it an error (does it prevent zoom-vanilla.js from loading)?

@litan1106
Copy link
Author

This is pretty accurate since the original zoom.js was written at a time before ES modules were common. Where do you see this notice, and is it an error (does it prevent zoom-vanilla.js from loading)?

I was using vite.js with react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants