diff --git a/content/en/changelogs/1.36.0-changelog.md b/content/en/changelogs/1.36.0-changelog.md index ba2f796f..bae1d0be 100644 --- a/content/en/changelogs/1.36.0-changelog.md +++ b/content/en/changelogs/1.36.0-changelog.md @@ -7,10 +7,45 @@ version: 1.36.0 ## Changelog +#### Breaking Changes + +##### Orca to Front50 Timeout Configuration + +Before [PR 4773](https://github.com/spinnaker/orca/pull/4773), these config properties and defaults controlled timeouts for orca to front50 communication (e.g. for saving a pipeline): +```yaml + ok-http-client: + connectTimeoutMs: 5000 + readTimeoutMs: 120000 + maxRequests: 100 + maxRequestsPerHost: 100 + connectionPool: + maxIdleConnections: 15 + keepAliveDurationMs: 30000 +``` +After PR #4773, the config properties changed to: +```yaml + front50: + okhttp: + connectTimeoutMs: 10000 + readTimeoutMs: 10000 + writeTimeoutMs: 10000 +``` +There's no equivalent for ok-http-client.maxRequests, maxRequestsPerHost, nor the connection pool properties after PR 4773. The defaults in okhttp are: + +- maxRequests: [64](https://github.com/square/okhttp/blob/parent-4.9.3/okhttp/src/main/kotlin/okhttp3/Dispatcher.kt#L46) +- maxRequestsPerHost: [5](https://github.com/square/okhttp/blob/parent-4.9.3/okhttp/src/main/kotlin/okhttp3/Dispatcher.kt#L65) +- maxIdleConnections: [5](https://github.com/square/okhttp/blob/parent-4.9.3/okhttp/src/main/kotlin/okhttp3/ConnectionPool.kt#L47) +- keepAliveDurationMs: [300000](https://github.com/square/okhttp/blob/parent-4.9.3/okhttp/src/main/kotlin/okhttp3/ConnectionPool.kt#L47) + +and they're no longer configurable. + +This is a behavior change, both for users who specified the ok-http-client properties, and those who relied on the defaults. To get the pre-1.36.0 timeouts, specify the front50.okhttp values as desired. +``` + ## Java upgrades Java 17 is now the default source and target. Java 11 support has been removed entirely. Please note you may need to add the following JAVA_OPTS options: ```--add-exports=java.base/sun.security.x509=ALL-UNNAMED --add-exports=java.base/sun.security.pkcs=ALL-UNNAMED --add-exports=java.base/sun.security.rsa=ALL-UNNAMED``` -to clouddriver if using GCP accounts due to credentials parsing of certificates. These can set in the [service-settings config](https://spinnaker.io/docs/reference/halyard/custom/#custom-service-settings). These configs are likely to be added to the defaults +to clouddriver if using GCP accounts due to credentials parsing of certificates. These can set in the [service-settings config](https://spinnaker.io/docs/reference/halyard/custom/#custom-service-settings). These configs are likely to be added to the defaults in all future releases ## Kleat is deprecated @@ -42,8 +77,10 @@ controller: ``` #### Orca + Updates Orca's SavePipelineTask to support bulk saves using the updated functionality in the front50 bulk save endpoint. + With https://github.com/spinnaker/orca/pull/4781, keys from the stage context's outputs section can now be removed (there by reducing the context size significantly). At present the following tasks support this feature: * PromoteManifestKatoOutputsTask @@ -88,7 +125,7 @@ stages: check-if-application-exists.enabled: true resize-server-group-stage: check-if-application-exists.enabled: true - + # cluster stages disable-cluster-stage: check-if-application-exists.enabled: true @@ -125,17 +162,17 @@ Configurable controls are added to decide whether cache should be refreshed whil controller: pipeline: save: - refreshCacheOnDuplicatesCheck: false // default is true + refreshCacheOnDuplicatesCheck: false // default is true ``` Batch update call now responds with a status of succeeded and failed pipelines info. The response will be a map containing information in the following format: -``` +``` [ "successful_pipelines_count" : , "successful_pipelines" : >, "failed_pipelines_count" : , - "failed_pipelines" : >> + "failed_pipelines" : >> ] ``` Here the value for `successful_pipelines` is the list of successful pipeline names whereas the value for `failed_pipelines` is the list of failed pipelines expressed as maps.