Merge pull request RobotLocomotion#80 from patmarion/add-drake-visualizer-binary

Add drake visualizer binary

Author: patmarion

distro/superbuild/cmake/externals.cmake

@@ -150,7 +150,7 @@ endif()
 # PythonQt
 ExternalProject_Add(PythonQt
   GIT_REPOSITORY https://github.com/commontk/PythonQt.git
-  GIT_TAG cbf890f
+  GIT_TAG 00e6c6b2
   CMAKE_CACHE_ARGS
     ${default_cmake_args}
     ${qt_args}

src/app/consoleApp.cpp

@@ -10,14 +10,10 @@ int main(int argc, char **argv)
   PythonQt::self()->addVariable(PythonQt::self()->importModule("sys"), "executable", QCoreApplication::applicationFilePath());
   int result = Py_Main(argc, argv);
 
-#ifdef Q_OS_MAC
-  // On MacOSX, there is a crash during PythonQt's finalization cleanup
-  // while destructing class metadata objects.
-#else
-  // crashes on Ubuntu 14.04 with Qt version 4.8.6
-  // this is a bug in PythonQt's finalize I think, to be investigated
-  //delete pythonManager;
-#endif
+  // delete pythonManager;
+  // Allow a leak to avoid a segfault in the PythonQt cleanup destructor.
+  // The segfault is fixed in upstream PythonQt, but we can't upgrade to
+  // that version yet because of a compile issue on Ubuntu 12 + Qt 4.8.
 
   return result;
 }

src/app/drakeVisualizerApp.cpp

@@ -5,9 +5,14 @@
 int main(int argc, char **argv)
 {
   QApplication app(argc, argv);
-  ddPythonManager pythonManager;
+  ddPythonManager* pythonManager = new ddPythonManager;
   PythonQt::self()->addVariable(PythonQt::self()->importModule("sys"), "executable", QCoreApplication::applicationFilePath());
-  pythonManager.executeString("import ddapp.drakevisualizer; ddapp.drakevisualizer.main(globals())");
+  pythonManager->executeString("import ddapp.drakevisualizer; ddapp.drakevisualizer.main(globals())");
+
+  // delete pythonManager;
+  // Allow a leak to avoid a segfault in the PythonQt cleanup destructor.
+  // The segfault is fixed in upstream PythonQt, but we can't upgrade to
+  // that version yet because of a compile issue on Ubuntu 12 + Qt 4.8.
 
   return 0;
 }

src/app/main.cpp

@@ -26,14 +26,10 @@ int main(int argc, char **argv)
 
   delete window;
 
-#ifdef Q_OS_MAC
-  // On MacOSX, there is a crash during PythonQt's finalization cleanup
-  // while destructing class metadata objects.
-#else
-  // crashes on Ubuntu 14.04 with Qt version 4.8.6
-  // this is a bug in PythonQt's finalize I think, to be investigated
-  //delete pythonManager;
-#endif
+  // delete pythonManager;
+  // Allow a leak to avoid a segfault in the PythonQt cleanup destructor.
+  // The segfault is fixed in upstream PythonQt, but we can't upgrade to
+  // that version yet because of a compile issue on Ubuntu 12 + Qt 4.8.
 
   return result;
 }