Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't poll the github API for development builds #93

Closed
ajessup opened this issue Nov 22, 2019 · 0 comments · Fixed by #94
Closed

Don't poll the github API for development builds #93

ajessup opened this issue Nov 22, 2019 · 0 comments · Fixed by #94
Assignees
Labels
help wanted Extra attention is needed

Comments

@ajessup
Copy link
Member

ajessup commented Nov 22, 2019

The "Get SPIRE" section of the spiffe.io website calls the github releases API to build the releases download page. Unfortunately as this API has a strict limit for unauthenticated callers, and it's triggered on each site rebuild, it's possible to exceed the limit. This in turn breaks site building.

The suggested fix is to ensure this API is not called when in "development mode". Ideally this would be accomplished by an optional CLI flag provided to hugo that when specified would cause the site to skip calling the GH releases API.

@ajessup ajessup assigned ajessup and lucperkins and unassigned ajessup Nov 22, 2019
@ajessup ajessup added the help wanted Extra attention is needed label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants