-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validated Versions Checkmark #273
Comments
Wouldn't it be better to make the values a range? I.E "2.9.9-2.10.0" |
Could be as well, yes, however, I'm not sure which one I prefer... In theory, we should always focus on the latest of everything as we've discussed again and again. Especially because you are talking about two different things. That is, it says that supports 2.9.9 and 1.1.88, but does it support 2.10.0 and 1.1.88? Or just 2.10.0 and 1.1.89? For this reason, I'd prefer to only guarantee the latest "pairing". |
@afonsojramos That's certainly a good point, one artifact of this though might be that it will allow us to let users on older versions of spicetify download older versions of extensions and themes(if we can somehow link the latest verified functional state in the manifest to the respective commit in the repository. ) |
Thinking in my head, that seems very complicated to do (fixing certain commit hashes, etc.), but it can be something to support in the future indeed. |
@afonsojramos Yeah, we'd have to add an array of commit id's in themes and extensions manifests and allow users to select which commit to use is probs that way I would do it. Handling it automatically would just lead to more errors imo |
@CharlieS1103 that sounds good actually, but let's move that discussion to later. Once we close this issue we can touch again on this. |
📝 Provide a description of the new feature
Add two checkmarks for each theme, extension, and custom app to "officially" validate that the latest version of Spotify / Spicetify is supported by it.
This would work by adding two fields in each of the manifests. If people wanted to get the checks on their extensions then they need to update these values with the latest. This way forces a community-led effort of better detailing/finding when/what is not working in new versions.
➕ Additional Information
This feature is dependent on the working mono-manifest implementation.
The text was updated successfully, but these errors were encountered: