Add new duplicate_declaration.{c,cpp} warning types (#13173)

Co-authored-by: Adam Turner <[email protected]>

Author: julien-lecomte

CHANGES.rst

@@ -18,6 +18,10 @@ Deprecated
 Features added
 --------------
 
+* Add a new ``duplicate_declaration`` warning type,
+  with ``duplicate_declaration.c`` and ``duplicate_declaration.cpp`` subtypes.
+  Patch by Julien Lecomte and Adam Turner.
+
 Bugs fixed
 ----------
 

doc/usage/configuration.rst

@@ -1374,6 +1374,8 @@ Options for warning control
    * ``config.cache``
    * ``docutils``
    * ``download.not_readable``
+   * ``duplicate_declaration.c``
+   * ``duplicate_declaration.cpp``
    * ``epub.unknown_project_files``
    * ``epub.duplicated_toc_entry``
    * ``i18n.inconsistent_references``
@@ -1444,6 +1446,9 @@ Options for warning control
    .. versionadded:: 8.0
       Added ``misc.copy_overwrite``.
 
+   .. versionadded:: 8.2
+      Added ``duplicate_declaration.c`` and ``duplicate_declaration.cpp``.
+
 
 Builder options
 ===============

sphinx/domains/c/__init__.py

@@ -284,6 +284,8 @@ def handle_signature(self, sig: str, signode: TextElement) -> ASTDeclaration:
                 self.display_object_type,
                 sig,
                 location=signode,
+                type='duplicate_declaration',
+                subtype='c',
             )
 
         if ast.objectType == 'enumerator':

sphinx/domains/c/_symbol.py

@@ -548,6 +548,8 @@ def merge_with(
                         our_child.declaration.directiveType,
                         name,
                         location=(other_child.docname, other_child.line),
+                        type='duplicate_declaration',
+                        subtype='c',
                     )
                 else:
                     # Both have declarations, and in the same docname.

sphinx/domains/cpp/__init__.py

@@ -397,6 +397,8 @@ def handle_signature(self, sig: str, signode: desc_signature) -> ASTDeclaration:
                 self.display_object_type,
                 sig,
                 location=signode,
+                type='duplicate_declaration',
+                subtype='cpp',
             )
 
         if ast.objectType == 'enumerator':

sphinx/domains/cpp/_symbol.py

@@ -895,6 +895,8 @@ def unconditional_add(self: Symbol, other_child: Symbol) -> None:
                         our_child.declaration.directiveType,
                         name,
                         location=(other_child.docname, other_child.line),
+                        type='duplicate_declaration',
+                        subtype='cpp',
                     )
                 else:
                     our_object_type = our_child.declaration.objectType