Stop taking app in create_source_parser() (#13639)

Author: AA-Turner

CHANGES.rst

@@ -7,6 +7,10 @@ Dependencies
 Incompatible changes
 --------------------
 
+* #13639: :py:meth:`!SphinxComponentRegistry.create_source_parser` no longer
+  has an *app* parameter, instead taking *config* and *env*.
+  Patch by Adam Turner.
+
 Deprecated
 ----------
 

sphinx/io.py

@@ -118,7 +118,7 @@ def create_publisher(app: Sphinx, filetype: str) -> Publisher:
     reader = SphinxStandaloneReader()
     reader._setup_transforms(registry=app.registry)
 
-    parser = app.registry.create_source_parser(app, filetype)
+    parser = app.registry.create_source_parser(filetype, config=app.config, env=app.env)
     if parser.__class__.__name__ == 'CommonMarkParser' and parser.settings_spec == ():
         # a workaround for recommonmark
         #   If recommonmark.AutoStrictify is enabled, the parser invokes reST parser

sphinx/registry.py

@@ -375,12 +375,14 @@ def get_source_parser(self, filetype: str) -> type[Parser]:
     def get_source_parsers(self) -> dict[str, type[Parser]]:
         return self.source_parsers
 
-    def create_source_parser(self, app: Sphinx, filename: str) -> Parser:
+    def create_source_parser(
+        self, filename: str, *, config: Config, env: BuildEnvironment
+    ) -> Parser:
         parser_class = self.get_source_parser(filename)
         parser = parser_class()
         if isinstance(parser, SphinxParser):
-            parser.config = app.config
-            parser.env = app.env
+            parser.config = config
+            parser.env = env
         return parser
 
     def add_translator(

sphinx/transforms/i18n.py

@@ -5,7 +5,6 @@
 import contextlib
 from re import DOTALL, match
 from textwrap import indent
-from types import SimpleNamespace
 from typing import TYPE_CHECKING, Any, TypeVar
 
 from docutils import nodes
@@ -109,9 +108,8 @@ def publish_msgstr(
         config.rst_prolog = None
 
         reader = _SphinxI18nReader(registry=registry)
-        app = SimpleNamespace(config=config, env=env, registry=registry)
         filetype = get_filetype(config.source_suffix, source_path)
-        parser = registry.create_source_parser(app, filetype)  # type: ignore[arg-type]
+        parser = registry.create_source_parser(filetype, config=config, env=env)
         doc = reader.read(
             source=StringInput(
                 source=source, source_path=f'{source_path}:{source_line}:<translated>'