-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
banner.css isn't added #23
Comments
That's odd. I can't reproduce it. Can you post the HTML of one of your pages here? |
Also the debug output of sphinx-versioning. That'll help too. |
Yup here is HTML
and here is the debug output
|
Are you using any other Sphinx extensions? Can you list them? |
Yea, here is the requirements file for the project.
|
I added a print line to sphinx_.py. Try installing the wip_debug branch (commit 4a7d692) |
Does it output something like:
|
Yup |
I pushed another print line to that branch (commit e3889b8) Does the file it prints exist?
|
Yup the file exists
|
|
Can you paste all of your conf.py file? Specifically are you setting any html_* variables (such as html_context)? |
|
There we go, that's it. readthedocs/readthedocs.org#2116 Setting html_context['css_files'] nukes all previously set css_files by other extensions. |
I can try to look into a way to have SCVersioning add its css file after all conf.py files are parsed so it won't be overridden. |
Ah I see, that seems like an annoying oversight. I can just manually add the banner.css for now since that is not to difficult. |
I'll try to fix it anyway since users might bake their css_files overrides in git tags. |
Ok, great. Thanks! |
Try the wip_css_override branch (commit e73b041). Should work without you needing to manually include banner.css. |
Yup that added
to the html but didn't copy banner.css into the _static folder. |
You mean that previous file path from the debug output no longer exists? |
Well the one that was printed out was within the sphinxcontrib-versioning checkout, not in my project. |
That's expected. Does the css render fine or does the browser say 404 in the JavaScript developer console? |
Console says 404 |
Looks like setting |
Let me know if you still have problems after I release 2.1.4. |
Using sphinxcontrib-versioning 2.1.3 (upgraded from 2.0.0)
config.py
Command Used
The banner template is rendered and injected fine but the banner.css doesn't get added.
The text was updated successfully, but these errors were encountered: