Sync from upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$_.LastLSN.ToString() -ge $LogBaseLsn $_.LastLSN.ToString() is STRING, but $LogBaseLsn is BIGINT. Powershell converts [BIGINT]$LogBaseLsn to string and after that compare these variables as strings.
* Added money type * Added txt data type * added min and maxvalue to money type * otsb
* Update Import-DbaXESessionTemplate.ps1 * Update Import-DbaXESessionTemplate.ps1
ApplicationIntent fixes
…nformation Fix Select-DbaBackupInformation
Updated example 3; Send-MailMessage only accepts string for -Body
Otherwise we may check to see if "sourceInstance default profile" exists on the destination then trying to create "destinationInstance default profile" which already exists.
Fixed path for output directory in Install-DbaMaintenanceSolution #4950
Addresses Status property spelling error for Successful status.
Adjusting the unit test for `tests/Get-DbaTraceFlag.Tests.ps1`
…tenanceSollution#4950 Update Install-DbaMaintenanceSolution.ps1 #4950
New improved unit tests - version2
…profile_name fields Also put single quotes around the account and profile name in messages for readability.
* adjusting content on contributing guide * adjusting readme content
Unit Test Updates, now uniform and simplified
* add missing unit tests * fix encoding
connstring fixes
Use ProviderPath property to allow for UNC paths
removed default on import-dbacsv
Import-DbaCsv Transactions
Changelog updates
* removed unnecessary params and added azure support * added feature parity to connect-dbainstance
Connect-SqlInstance -> Connect-DbaInstance
* add debug by default and dbatools_enabledebug * remove missing files * discard leftovers * put dac back
* more azure fixes * return azure connstring * add new db support for azure * remove open requirement
* made azure compliant, probably * fix path for azure * fix - before i was getting null exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change