Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

61 feature eldritch fileis file #69

Merged
merged 4 commits into from
Oct 30, 2022
Merged

61 feature eldritch fileis file #69

merged 4 commits into from
Oct 30, 2022

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Oct 21, 2022

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

This PR adds a file.is_file feature to eldritch.

Which issue(s) this PR fixes:

Fixes #61

@hulto hulto linked an issue Oct 21, 2022 that may be closed by this pull request
[feature] Eldritch file.is_file #61
Closed
Milkshak3s
Milkshak3s approved these changes Oct 30, 2022
View reviewed changes
Copy link
Collaborator

@Milkshak3s Milkshak3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hulto hulto merged commit 71fc8bc into main Oct 30, 2022
@hulto hulto deleted the 61-feature-eldritch-fileis_file branch October 30, 2022 19:54
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
98a7cbb 
 
61 feature eldritch fileis file (#69)

* Added is_file stubs.

* Add file.is_file code and tests.

* Added is_file to lib_bindings test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milkshak3s Milkshak3s Milkshak3s approved these changes

@Cictrone Cictrone Awaiting requested review from Cictrone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Eldritch file.is_file
2 participants
@hulto @Milkshak3s