Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terms): Add description on pages, update links #672

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Feb 26, 2024

/kind cleanup
/kind documentation

What this PR does / why we need it:

  • Adds description to hosts/tasks/quests
  • Changes nav bar items
  • Changes links to tome now that the documentation exists
  • Updates doc language on term page to match descriptions

@cmp5987 cmp5987 requested a review from hulto February 26, 2024 16:57
@cmp5987 cmp5987 added documentation Improvements or additions to documentation Frontend labels Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.71%. Comparing base (21ccdce) to head (ccd8918).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files         175      175           
  Lines       12086    12086           
=======================================
  Hits         8668     8668           
  Misses       3203     3203           
  Partials      215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs thoughts

docs/_docs/user-guide/terminology.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/terminology.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/terminology.md Outdated Show resolved Hide resolved
docs/_docs/user-guide/terminology.md Outdated Show resolved Hide resolved
@cmp5987 cmp5987 requested a review from hulto February 26, 2024 18:21
hulto
hulto previously approved these changes Feb 26, 2024
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please swap agent term back to OG

@cmp5987 cmp5987 merged commit e6a8a28 into main Feb 26, 2024
8 checks passed
@cmp5987 cmp5987 deleted the cp-update-text-and-terms branch February 26, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants