Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a file.mkdir tome and also added a parent param similar to linux's #666

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

Cictrone
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

Rayne NEEDS this

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.06%. Comparing base (9a22eb0) to head (ab3fed8).

Files Patch % Lines
implants/lib/eldritch/src/file/mkdir_impl.rs 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   72.02%   72.06%   +0.03%     
==========================================
  Files         175      175              
  Lines       11998    12017      +19     
==========================================
+ Hits         8642     8660      +18     
- Misses       3142     3143       +1     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tavern/tomes/file_mkdir/metadata.yml Outdated Show resolved Hide resolved
tavern/tomes/file_mkdir/main.eldritch Show resolved Hide resolved
tavern/tomes/download/main.eldritch Outdated Show resolved Hide resolved
implants/lib/eldritch/src/file/mkdir_impl.rs Show resolved Hide resolved
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rayne I hope your dir adventures are fruitful

@Cictrone Cictrone merged commit 1751355 into main Feb 25, 2024
8 checks passed
@Cictrone Cictrone deleted the raynes-feature branch February 25, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants