Fix lint warn. #663
Closed
Fix lint warn. #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
=======================================
Coverage 72.02% 72.02%
=======================================
Files 175 175
Lines 12008 12008
=======================================
Hits 8649 8649
Misses 3145 3145
Partials 214 214 ☔ View full report in Codecov by Sentry. |
Cictrone
reviewed
Feb 25, 2024
| @@ -52,10 +52,8 @@ fn handle_get_ip() -> Result<Vec<NetInterface>> { | |||
| Some(netmask) => { | |||
| let cidr = netmask_to_cidr(netmask)?; | |||
| ips.push(format!("{}/{}", ip.ip(), cidr)); | |||
| }, | |||
| None => { | |||
| ips.push(ip.ip().to_string()) | |||
| } | |||
There was a problem hiding this comment.
im afraid at the lack of comma... but it compiles :o
|
Duped by #665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #