626 support globbing in rust #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KCarretto
previously approved these changes
Feb 19, 2024
| sys.refresh_users_list(); | ||
| let file_name = path_entry | ||
| .file_name() |
|
Needs to be fixed for windows: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 71.00% 71.20% +0.19%
==========================================
Files 170 170
Lines 11414 11500 +86
==========================================
+ Hits 8104 8188 +84
- Misses 3096 3098 +2
Partials 214 214 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds glob (*) support to
file.readandfile.listWhich issue(s) this PR fixes:
Fixes #626