Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Paginate Quests #619

Merged
merged 8 commits into from
Feb 26, 2024
Merged

[feature] Paginate Quests #619

merged 8 commits into from
Feb 26, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds pagination to Quest GraphQL Root Query

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.76%. Comparing base (e6a8a28) to head (18cc3c1).

Files Patch % Lines
tavern/internal/ent/schema/quest.go 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   71.71%   71.76%   +0.04%     
==========================================
  Files         175      175              
  Lines       12086    12111      +25     
==========================================
+ Hits         8668     8691      +23     
- Misses       3203     3205       +2     
  Partials      215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cictrone
Cictrone previously approved these changes Feb 19, 2024
@cmp5987
Copy link
Collaborator

cmp5987 commented Feb 26, 2024

Updated UI to get data from the nested 'edges' and 'node'.

cmp5987
cmp5987 previously approved these changes Feb 26, 2024
Copy link
Collaborator

@cmp5987 cmp5987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added UI support to avoid breaking changes

@cmp5987 cmp5987 merged commit b25fd49 into main Feb 26, 2024
6 checks passed
@cmp5987 cmp5987 deleted the quest-pagination branch February 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants