Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support to be compiled as a windows service. #604

Merged
merged 10 commits into from
Feb 17, 2024
Merged

Adds support to be compiled as a windows service. #604

merged 10 commits into from
Feb 17, 2024

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Feb 17, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allows imix to compile to a windows service exe.

  • Tested locally: Service starts successfully
  • Made sure it called back
  • Add docs to compile for windows service

Which issue(s) this PR fixes:

Fixes #375

Cictrone
Cictrone previously approved these changes Feb 17, 2024
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, windows is sus

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (e2e9a57) 71.55% compared to head (5439c4a) 71.59%.

Files Patch % Lines
implants/imix/src/lib.rs 0.00% 31 Missing ⚠️
implants/imix/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
+ Coverage   71.55%   71.59%   +0.03%     
==========================================
  Files         166      167       +1     
  Lines       10999    10993       -6     
==========================================
  Hits         7870     7870              
+ Misses       2950     2944       -6     
  Partials      179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulto hulto merged commit 8d8d457 into main Feb 17, 2024
7 of 8 checks passed
@hulto hulto deleted the win-service branch February 17, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow imix to compile to a windows service.
2 participants