Regex-lib-stub #601
Merged
Regex-lib-stub #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulto
previously approved these changes
Feb 16, 2024
KCarretto
reviewed
Feb 16, 2024
| @@ -357,7 +357,8 @@ The <b>file.remove</b> method deletes a file or directory (and it's contents) sp | |||
| ### file.replace | |||
|
|
|||
| `file.replace(path: str, pattern: str, value: str) -> None` | |||
| The <b>file.replace</b> method is very cool, and will be even cooler when Nick documents it. | |||
|
|
|||
| Unimplemented. | |||
There was a problem hiding this comment.
Trying to escape responsibility I see
KCarretto
previously approved these changes
Feb 16, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
==========================================
- Coverage 70.97% 70.95% -0.02%
==========================================
Files 161 166 +5
Lines 10776 10801 +25
==========================================
+ Hits 7648 7664 +16
- Misses 2949 2958 +9
Partials 179 179 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind eldritch-library
What this PR does / why we need it:
for our string-oriented fiends
Which issue(s) this PR fixes:
Fixes QoL