Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix Credential Kind Enum #597

Merged
merged 2 commits into from
Feb 14, 2024
Merged

[bug] Fix Credential Kind Enum #597

merged 2 commits into from
Feb 14, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes the credential enum (was accidentally using copy+pasta'd process value map)

Cictrone
Cictrone previously approved these changes Feb 14, 2024
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheeky

hulto
hulto previously approved these changes Feb 14, 2024
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KCarretto KCarretto dismissed stale reviews from hulto and Cictrone via 776c838 February 14, 2024 04:32
@KCarretto KCarretto merged commit f0ae9e2 into main Feb 14, 2024
4 of 6 checks passed
@KCarretto KCarretto deleted the fix-creds-enum branch February 14, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants