Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers and recursive depth to file_list #575

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Conversation

nullmonk
Copy link
Collaborator

@nullmonk nullmonk commented Feb 11, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Enhance the file_list tome with the following features

  • Added support for recursive depth in file listing
  • Added permission check for listing directories
  • Add headers to top of printout
  • Print full file path

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42154cf) 71.13% compared to head (f7a5bae) 71.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files         147      147           
  Lines       10314    10314           
=======================================
  Hits         7337     7337           
  Misses       2798     2798           
  Partials      179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move recursion to the file_tree tome.
We'll work on adding rwx to eldritch natively but looks good to me.

hulto
hulto previously approved these changes Feb 14, 2024
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise LGTM

tavern/tomes/file_list/main.eldritch Outdated Show resolved Hide resolved
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One docs ask.

tavern/tomes/file_list/metadata.yml Show resolved Hide resolved
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

@nullmonk nullmonk merged commit acaae92 into main Feb 15, 2024
8 checks passed
@nullmonk nullmonk deleted the update-file-list branch February 15, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants