[bug] Fix file download #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also apparently windows is madge lol (what's new?) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
+ Coverage 69.75% 70.32% +0.56%
==========================================
Files 139 139
Lines 10071 10149 +78
==========================================
+ Hits 7025 7137 +112
+ Misses 2880 2846 -34
Partials 166 166 ☔ View full report in Codecov by Sentry. |
nullmonk
pushed a commit
that referenced
this pull request
Feb 14, 2024
* fix file download * fix nits * fix tests * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes our assets.copy implementation, as well as an issue with how imix was downloading files for tasks.