Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the clippy fix on save #523

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Removes the clippy fix on save #523

merged 1 commit into from
Jan 30, 2024

Conversation

Cictrone
Copy link
Collaborator

It was causing holding a write lock on the files for too long making iteration annoying.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Save @hulto's sanity.

… lock on the files for too long making iteration annoying.
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46187f4) 66.04% compared to head (bf872f0) 70.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   66.04%   70.56%   +4.51%     
==========================================
  Files         126      126              
  Lines        9012     9587     +575     
==========================================
+ Hits         5952     6765     +813     
+ Misses       2914     2676     -238     
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cictrone Cictrone merged commit 54d8d1c into main Jan 30, 2024
8 checks passed
@Cictrone Cictrone deleted the remove-clippy-fix-onsave branch January 30, 2024 18:46
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
removes the clippy fix on save because it was causing holding a write lock on the files for too long making iteration annoying. (#523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant