-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
445 improve docs to better outline the tome creation process #519
Merged
hulto
merged 5 commits into
main
from
445-improve-docs-to-better-outline-the-tome-creation-process
Jan 30, 2024
Merged
445 improve docs to better outline the tome creation process #519
hulto
merged 5 commits into
main
from
445-improve-docs-to-better-outline-the-tome-creation-process
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cictrone
previously approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some nits
KCarretto
requested changes
Jan 30, 2024
KCarretto
approved these changes
Jan 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
=======================================
Coverage 70.56% 70.56%
=======================================
Files 126 126
Lines 9587 9587
=======================================
Hits 6765 6765
Misses 2676 2676
Partials 146 146 ☔ View full report in Codecov by Sentry. |
hulto
deleted the
445-improve-docs-to-better-outline-the-tome-creation-process
branch
January 30, 2024 02:05
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Updates docs around tome creation.
Which issue(s) this PR fixes:
Fixes #445