513 update file tree tome to default exclude extraneous dirs #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 70.52% 70.56% +0.03%
==========================================
Files 126 126
Lines 9591 9587 -4
==========================================
+ Hits 6764 6765 +1
+ Misses 2681 2676 -5
Partials 146 146 ☔ View full report in Codecov by Sentry. |
KCarretto
reviewed
Jan 30, 2024
implants/lib/eldritch/src/runtime.rs
Outdated
| @@ -28,7 +28,7 @@ use std::time::Duration; | |||
| */ | |||
| #[derive(ProvidesStaticType)] | |||
| pub struct Runtime { | |||
| stdout_reporting: bool, | |||
| pub stdout_reporting: bool, | |||
There was a problem hiding this comment.
this doesn't need to be pub, see with_stdout_reporting
KCarretto
requested changes
Jan 30, 2024
| Ok(response) => (0, response), | ||
| Err(error) => { | ||
| eprint!("failed to execute tome {:?}", error); | ||
| (-1, Vec::new()) | ||
| } | ||
| }; | ||
|
|
||
| if !result.is_empty() { |
There was a problem hiding this comment.
Maybe we should just print without the :?, that might avoid escaping strings and then we can get rid of the with_stdout_reporting API.
There was a problem hiding this comment.
We need to keep the with_stdout_reporting API.
If the tome crashes no output gets printed making it very hard to debug.
KCarretto
approved these changes
Jan 30, 2024
hulto
deleted the
513-update-file-tree-tome-to-default-exclude-extraneous-dirs
branch
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Remove unused output from file tree output.
Output is now:
Instead of:
Which issue(s) this PR fixes:
Fixes #513
Fixes #517