-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process info tome #508
Process info tome #508
Conversation
Added eldritch code and metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test when I get home but looks very promising
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 70.52% 70.52%
=======================================
Files 126 126
Lines 9591 9591
=======================================
Hits 6764 6764
Misses 2681 2681
Partials 146 146 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit otherwise LGTM.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added tome for getting process information or the current process if -1 is specified. I tried a few different formats for the output think this one looks okay but let me know if you think it needs tweaking. Also the eldritch documentation indicates that the "cmd" and "environ" keys in the dict should be list/arrays but currently they're just one big string.
Which issue(s) this PR fixes:
Fixes #490