Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process info tome #508

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Conversation

Alextibtab
Copy link
Contributor

@Alextibtab Alextibtab commented Jan 26, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added tome for getting process information or the current process if -1 is specified. I tried a few different formats for the output think this one looks okay but let me know if you think it needs tweaking. Also the eldritch documentation indicates that the "cmd" and "environ" keys in the dict should be list/arrays but currently they're just one big string.

Which issue(s) this PR fixes:

Fixes #490

Added eldritch code and metadata
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test when I get home but looks very promising

tavern/tomes/process_info/main.eldritch Show resolved Hide resolved
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bafde7) 70.52% compared to head (1e3cc55) 70.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files         126      126           
  Lines        9591     9591           
=======================================
  Hits         6764     6764           
  Misses       2681     2681           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hulto
hulto previously approved these changes Jan 27, 2024
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit otherwise LGTM.

tavern/tomes/process_info/main.eldritch Show resolved Hide resolved
@hulto hulto merged commit dee0692 into spellshift:main Jan 28, 2024
8 checks passed
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Process info tome (#508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a process info tome
2 participants