Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file/directory removal tome #500

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

Alextibtab
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add new tome for deleting files/directories

Which issue(s) this PR fixes:

Fixes #489

Let me know if any of the metadata values need changing. Also wasn't sure what the newline padding is for but I assume it's convention. I did a quick test in the dev container and it successfully removed both files and directories.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2193142) 71.16% compared to head (67aaa7b) 71.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   71.16%   71.16%           
=======================================
  Files         125      125           
  Lines        9922     9922           
=======================================
  Hits         7061     7061           
  Misses       2717     2717           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@hulto hulto merged commit 688da43 into spellshift:main Jan 24, 2024
8 checks passed
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Add file/directory removal tome (#500)

* Issue #489 Implement File Removal Tome.

Added eldritch code and yaml metadata.

* Simplified eldritch code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement file remove tome
2 participants