Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cp improve data #460

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Cp improve data #460

merged 3 commits into from
Jan 22, 2024

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Jan 22, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds tome details to output
  • Adds creator details to output
  • Shrinks the amount of data returned from quest list

Screenshot

Screenshot 2024-01-22 at 5 15 53 PM

@cmp5987 cmp5987 requested a review from hulto January 22, 2024 22:07
hulto
hulto previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d029e59) 71.32% compared to head (660a393) 71.32%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   71.32%   71.32%           
=======================================
  Files         120      120           
  Lines        9411     9411           
=======================================
  Hits         6712     6712           
  Misses       2573     2573           
  Partials      126      126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulto hulto merged commit 5bbbb33 into main Jan 22, 2024
8 checks passed
@hulto hulto deleted the cp-improve-data branch January 22, 2024 22:27
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@cmp5987
0b99e37 
 
Cp improve data (#460)

* fix(output): Expand output data

* fix(build): Run build ui

* fix(console): Remove console log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmp5987 @hulto