Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cp search tome #435

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Cp search tome #435

merged 4 commits into from
Jan 15, 2024

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Jan 15, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds generated quest names
  • Expands details and styling for tomes
  • Moves name to separate step with confirmation details
  • Adds searching component for tomes

Which issue(s) this PR fixes:

Fixes #402
Fixes #365

Screenshots

Screenshot 2024-01-15 at 2 44 34 PM Screenshot 2024-01-15 at 2 44 53 PM Screenshot 2024-01-15 at 2 45 05 PM Screenshot 2024-01-15 at 2 46 03 PM

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36de97c) 71.46% compared to head (ea25020) 71.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files         115      115           
  Lines        8835     8835           
=======================================
  Hits         6314     6314           
  Misses       2412     2412           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hulto hulto merged commit 933c89d into main Jan 15, 2024
8 checks passed
@hulto hulto deleted the cp-search-tome branch January 15, 2024 21:55
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Cp search tome (#435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto generate quest names
2 participants