time.now #404
Merged
time.now #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 71.75% 71.77% +0.02%
==========================================
Files 107 108 +1
Lines 7910 7923 +13
==========================================
+ Hits 5676 5687 +11
- Misses 2125 2127 +2
Partials 109 109 ☔ View full report in Codecov by Sentry. |
hulto
reviewed
Dec 17, 2023
| use anyhow::Result; | ||
|
|
||
| pub fn now() -> Result<u64> { | ||
| Ok(SystemTime::now().duration_since(UNIX_EPOCH)?.as_secs()) |
There was a problem hiding this comment.
Hell yeah UNIX EPOCH 😎
Is there a reason (for windows folks) to do Windows EPOCH on windows hosts?
There was a problem hiding this comment.
I don't think so, tbh I need to make a timestamp to epoch eldritch function and vice versa to make this easier for ppl.
hulto
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
/kind feature
/kind eldritch-function
What this PR does / why we need it:
Adds
time.now()to return local system timeWhich issue(s) this PR fixes:
Fixes #76