Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imix main testing #384

Merged
merged 29 commits into from
Dec 8, 2023
Merged

Imix main testing #384

merged 29 commits into from
Dec 8, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Dec 2, 2023

What type of PR is this?

/cleanup

What this PR does / why we need it:

Cleans up imix main loop and testing

Which issue(s) this PR fixes:

Fixes #

@hulto hulto added cleanup Code cleanup and tech debt removal imix labels Dec 2, 2023
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 276 lines in your changes are missing coverage. Please review.

Comparison is base (c0b59bf) 62.30% compared to head (05514b9) 71.72%.

Files Patch % Lines
implants/imix/src/tasks.rs 30.05% 128 Missing ⚠️
implants/imix/src/main.rs 1.38% 71 Missing ⚠️
implants/imix/src/init.rs 77.66% 44 Missing ⚠️
implants/imix/src/exec.rs 73.17% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   62.30%   71.72%   +9.41%     
==========================================
  Files          30      107      +77     
  Lines        1812     7901    +6089     
==========================================
+ Hits         1129     5667    +4538     
- Misses        574     2125    +1551     
  Partials      109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it looks nice!

implants/imix/src/exec.rs Outdated Show resolved Hide resolved
implants/imix/src/exec.rs Outdated Show resolved Hide resolved
implants/imix/src/exec.rs Outdated Show resolved Hide resolved
implants/imix/src/exec.rs Outdated Show resolved Hide resolved
implants/imix/src/exec.rs Outdated Show resolved Hide resolved
implants/imix/src/exec.rs Outdated Show resolved Hide resolved
implants/imix/src/exec.rs Outdated Show resolved Hide resolved
implants/imix/src/init.rs Show resolved Hide resolved
@hulto hulto marked this pull request as ready for review December 3, 2023 23:06
@hulto hulto marked this pull request as draft December 3, 2023 23:07
@hulto hulto marked this pull request as ready for review December 4, 2023 15:36
Copy link
Collaborator

@jabbate19 jabbate19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hulto hulto requested a review from Cictrone December 8, 2023 16:23
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emergency approve, no look

@hulto hulto merged commit c122a52 into main Dec 8, 2023
7 of 8 checks passed
@hulto hulto deleted the imix-main-testing branch December 8, 2023 16:37
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Imix main testing (#384)

* Remove install option.

* Move agent init to init.rs

* Split imix exec function out.

* Refactor sleep time math to use saturation.

* Update graphql to grpc.

* Change debug prints to eprintln.

* Adding tests.

* Update IDs to i64

* Disable timeout test.

* Refactoring

* Type alias task id

* testing for init mod

* Testing output

* Check system ID is written.

* test system config file.

* Switch agent init to take host-id path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup and tech debt removal imix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants