Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unactivated users to query Me() graphql #344

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Allow unactivated users to query Me() graphql #344

merged 2 commits into from
Oct 30, 2023

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Allow unactivated users to perform the GraphQL Me query. This will enable the UI to query information about users who have not yet been approved by an administrator.

Which issue(s) this PR fixes:

Fixes #339

Copy link
Collaborator

@cmp5987 cmp5987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick change

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #344 (d7dcd6f) into main (753bd6a) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   75.38%   75.40%   +0.01%     
==========================================
  Files         103      103              
  Lines        6732     6732              
==========================================
+ Hits         5075     5076       +1     
+ Misses       1570     1569       -1     
  Partials       87       87              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KCarretto KCarretto merged commit a6c60cd into main Oct 30, 2023
5 checks passed
@KCarretto KCarretto deleted the fix-me branch October 30, 2023 00:51
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
Allow unactivated users to query Me() graphql (#344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Me endpoint currently requires authorization
2 participants