Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cp final fix auth #341

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Cp final fix auth #341

merged 2 commits into from
Oct 29, 2023

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Oct 29, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Changes to
  • Moves render logic outside of context provider

@cmp5987 cmp5987 requested a review from hulto October 29, 2023 21:07
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #341 (1986e14) into main (85710e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   75.20%   75.20%           
=======================================
  Files         101      101           
  Lines        6607     6607           
=======================================
  Hits         4969     4969           
  Misses       1551     1551           
  Partials       87       87           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmp5987 cmp5987 merged commit 4b403b4 into main Oct 29, 2023
8 checks passed
@cmp5987 cmp5987 deleted the cp-final-fix-auth branch October 29, 2023 21:26
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Cp final fix auth (#341)

* fix(auth): Fix auth state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants